feat(ucs): add event logging for UCS operations#9058
Merged
likhinbopanna merged 13 commits intomainfrom Sep 2, 2025
Merged
Conversation
Changed Files
|
jarnura
previously approved these changes
Aug 26, 2025
su-shivanshmathur
requested changes
Aug 26, 2025
920e113 to
8f71162
Compare
su-shivanshmathur
previously approved these changes
Aug 28, 2025
hrithikesh026
requested changes
Aug 28, 2025
| /// It logs the actual gRPC request/response data, timing, and error information. | ||
| #[instrument(skip_all, fields(connector_name, flow_type, payment_id))] | ||
| pub async fn ucs_logging_wrapper<T, F, Fut, Req, Resp, GrpcReq, GrpcResp>( | ||
| router_data: RouterData<T, Req, Resp>, |
Contributor
There was a problem hiding this comment.
I think This can be a mutable ref. Can avoid cloning router data as well
Suggested change
| router_data: RouterData<T, Req, Resp>, | |
| router_data: &mut RouterData<T, Req, Resp>, |
Contributor
Author
There was a problem hiding this comment.
The mutable reference approach creates lifetime issues with async closures - Rust can't move borrowed references in async move blocks.
hrithikesh026
previously approved these changes
Aug 29, 2025
su-shivanshmathur
previously approved these changes
Aug 29, 2025
1aaf9f3
hrithikesh026
previously approved these changes
Sep 1, 2025
su-shivanshmathur
approved these changes
Sep 2, 2025
hrithikesh026
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added comprehensive event logging for UCS operations to improve debugging and monitoring. The changes wrap UCS calls with structured logging that captures request/response data, timing, and errors across all payment flows.
Additional Changes
Motivation and Context
How did you test it?
Enable UCS
Enable UCS authorize
Payments - Create
Logs (Success)


Logs(Failure)
Checklist
cargo +nightly fmt --allcargo clippy