Skip to content

Call multiple connectors#90

Merged
jarnura merged 45 commits intomainfrom
call_multiple_connectors
Dec 9, 2022
Merged

Call multiple connectors#90
jarnura merged 45 commits intomainfrom
call_multiple_connectors

Conversation

@Narayanbhat166
Copy link
Contributor

@Narayanbhat166 Narayanbhat166 commented Dec 7, 2022

Type of Change

  • New feature

Description

  • To call multiple connectors for creating the sessions token which is needed for Wallets.
  • Payment data parameter has been removed from decide_flows as it was never being used, can be included in future if needed.
  • Add sessions_token field to payment_data struct, this will store all the sessions token collected from connectors.

Motivation and Context

A single api call should return the sessions token for all the wallets merchant has enabled. This PR has the change which adds a function call_multiple_connectors which will take vector of connectors and call them in sequence ( should be optimized to call connectors in parallel ).

How did you test it?

NA

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

Narayanbhat166 and others added 19 commits December 4, 2022 17:02
@Narayanbhat166
feat(core): add sessions flow
ca6be1a
@Narayanbhat166
fix(core): remove store cast to dyn db
67b814a
@Narayanbhat166
refactor(core): fix pr comments
8dbb806
@Narayanbhat166
refactor(core): change variable declaration method'
a247cf2
@Narayanbhat166
Merge branch 'main' into sessions_flow_for_wallets
015ad86
@Narayanbhat166
refactor(core): make payments response data enum
ff79049
@Narayanbhat166
refactor(core): modify existing code to support new payment data
a7c788b
@Narayanbhat166
fix(connector): errors caused by merge
5243715
@Narayanbhat166
refactor(core): change response type for sessiontrait
6bf53db
@Narayanbhat166
refactor(core): remove construct router data for sessions
fb925d3
@Narayanbhat166
fix(tests): modify to accomodate change to payments response data
62cfeca
@Narayanbhat166
Merge branch 'main' into sessions_flow_for_wallets
e7ed354
@Narayanbhat166
fix(core): errors caused by the merge
ba79c26
@Narayanbhat166
fix(core): cargo fmt
c842f06
@Narayanbhat166
refactor(core): remove paymentdata from decide flow
60a0445
@Narayanbhat166
fix(core): clippy warnings
4edbc9f
@Narayanbhat166
Merge branch 'main' into sessions_flow_for_wallets
cf50e61
@Narayanbhat166
fix(core): merge fixes
7eaee84
@Narayanbhat166
feat(core): add call multiple connectors sequential
c51d74f
@Narayanbhat166 Narayanbhat166 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 7, 2022
@Narayanbhat166 Narayanbhat166 self-assigned this Dec 7, 2022
dracarys18
dracarys18 suggested changes Dec 8, 2022
View reviewed changes
jarnura
jarnura reviewed Dec 9, 2022
View reviewed changes
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 9, 2022
@Narayanbhat166 Narayanbhat166 removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Dec 9, 2022
jarnura
jarnura reviewed Dec 9, 2022
View reviewed changes
jarnura
jarnura reviewed Dec 9, 2022
View reviewed changes
Base automatically changed from sessions_flow_for_wallets to main December 9, 2022 15:28
dracarys18
dracarys18 previously approved these changes Dec 9, 2022
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Dec 9, 2022
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Dec 9, 2022
View reviewed changes
@jarnura jarnura merged commit 091d5af into main Dec 9, 2022
@SanchithHegde SanchithHegde mentioned this pull request Feb 28, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Sangamesh26 Sangamesh26 Awaiting requested review from Sangamesh26

+1 more reviewer

@dracarys18 dracarys18 dracarys18 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Narayanbhat166 Narayanbhat166

Labels

A-core Area: Core flows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Narayanbhat166 @jarnura @SanchithHegde @dracarys18