feat(payment-methods): [Proxy] add saved card flow for proxy payments by Sakilmostak · Pull Request #8964 · juspay/hyperswitch

Sakilmostak · 2025-08-14T11:58:33Z

Type of Change

Description

Add saved card flow for proxy payments:

Card metadata is collected in the request along with tokens (bin_number and last_four digits for Card Number)
Card Bin API is used to fetch data against card like card_network and issuer using bin number
Card metadata is stored in payment method table along with tokens
This component works along with Proxy Payments (needs confirm-intent/external-vault-proxy)
Internally no locker is used since we don't store raw card data
Data for subsequent payments (tokens) are fetched from payment method table
Only cvc and card_holder_name is collected in subsequent payment with saved card

Additional Changes

This PR modifies the API contract
First payment to save card in confirm-intent/external-vault-proxy:

"payment_method_data": {
        "vault_data_card": {
            "card_number": "tok_sandbox_ZgPN54WU8y8tDjc6qfEs",
            "card_exp_month": "04",
            "card_exp_year": "29",
            "card_cvc": "tok_sandbox_3EniLX4zKbwxV1PPZFopd",
            "bin_number": "424242",
            "last_four": "4242",
            "card_holder_name": "john doe"
        }
    },

Subsequent payment with saved card in confirm-intent/external-vault-proxy:

"payment_method_data": {
        "vault_token": {
            "card_cvc": "737"
        }
    },

This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

This PR is dependent in proxy module. Need the whole module to be present for testing.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…h into add-confirm-proxy-flow

semanticdiff-com · 2025-08-14T11:58:35Z

Review changes with

Changed Files

File	Status
crates/router/src/core/payments/operations/payment_confirm_intent.rs	100% smaller
crates/router/src/core/payment_methods/vault.rs	92% smaller
crates/router/src/types/api/payment_methods.rs	86% smaller
crates/hyperswitch_domain_models/src/vault.rs	32% smaller
crates/api_models/src/payments.rs	11% smaller
crates/openapi/src/openapi_v2.rs	9% smaller
crates/router/src/core/payments/operations/external_vault_proxy_payment_intent.rs	6% smaller
crates/hyperswitch_domain_models/src/payment_method_data.rs	6% smaller
crates/router/src/core/payment_methods.rs	1% smaller
api-reference/v2/openapi_spec_v2.json	0% smaller
crates/api_models/src/payment_methods.rs	0% smaller
crates/common_enums/src/enums.rs	0% smaller
crates/diesel_models/src/payment_method.rs	0% smaller
crates/diesel_models/src/schema_v2.rs	0% smaller
crates/hyperswitch_domain_models/src/payment_methods.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_attempt.rs	0% smaller
crates/router/src/core/payments.rs	0% smaller
crates/router/src/core/payments/operations.rs	0% smaller
crates/router/src/core/unified_connector_service.rs	0% smaller
v2_compatible_migrations/2025-07-29-080133_add-external_vault_token_data-column-to-payment-methods/down.sql	Unsupported file format
v2_compatible_migrations/2025-07-29-080133_add-external_vault_token_data-column-to-payment-methods/up.sql	Unsupported file format

crates/router/src/core/payments/operations/external_vault_proxy_payment_intent.rs

prasunna09 · 2025-08-18T10:06:47Z

crates/router/src/core/payments/operations/external_vault_proxy_payment_intent.rs

+                let payment_method_id = common_utils::id_type::GlobalPaymentMethodId::generate(
+                    &state.conf.cell_information.id,
+                )


do not generate pm id in payments service. this should be handled by pm service only

prasunna09 · 2025-08-18T18:06:49Z

crates/api_models/src/payment_methods.rs

+pub struct ProxyCardDetails {
+    /// Tokenized Card Number
+    #[schema(value_type = String,example = "4111111145551142")]
+    pub card_number: masking::Secret<String>,


we ll have to ensure actual card raw num is not stored in pm entry.
may be we can do a luhn check before storing in pm table?

Im taking it in a separate pr

prasunna09 · 2025-08-18T18:24:29Z

crates/router/src/core/payments/operations/payment_response.rs

+            payment_data.payment_attempt.customer_acceptance.is_some(),
+            payment_data.payment_attempt.payment_method_id.clone(),
+        ) {
+            payment_methods::update_payment_method_status_internal(


We ll have to introduce a new endpoint to activate the pm for internal use, instead payments directly calling update fn

Created a issue that could be picked up https://github.com/juspay/hyperswitch-cloud/issues/10702

..._migrations/2025-07-29-080133_add-external_vault_token_data-column-to-payment-methods/up.sql

crates/router/src/core/payments/operations/payment_response.rs

prasunna09 · 2025-08-20T08:21:45Z

crates/common_enums/src/enums.rs

    }
+
+    pub fn is_success(self) -> bool {
+        matches!(self, Self::Charged | Self::PartialCharged)


we should update payment method to active if Authentication is successful and other successful status. Even in psync flow, the update payment method should happen
We can pick this up in a seperate pr.

prasunna09 and others added 19 commits July 17, 2025 01:53

add support for proxy confirm flow

41461e3

add confirm proxy flow

9cd428b

feat: add saved card flow for proxy payments

1af6ebc

add merchant proxy url to build request

bf4119d

add merchant proxy url to build request

28fc7b9

refactor: fix bug for saved card proxy

0789e22

add ucs call in external proxy confirm intent

3a903f1

code refactoring

4ca7455

code refactoring

210112c

fix fmt

83bbdfa

remove unnecessary comments

fcee89b

code refactoring

723939d

Merge branch 'main' into add-confirm-proxy-flow

5f01bac

fix clippy

e9fb498

chore: run formatter

c823e3c

fix clippy

8fb888e

Merge branch 'add-confirm-proxy-flow' of github.com:juspay/hyperswitc…

b4d745a

…h into add-confirm-proxy-flow

chore: run formatter

963c5ce

Merge branch 'main' into add-confirm-proxy-flow

209969c

Sakilmostak self-assigned this Aug 14, 2025

Sakilmostak requested review from a team as code owners August 14, 2025 11:58

Sakilmostak added the A-core Area: Core flows label Aug 14, 2025

Sakilmostak requested a review from a team as a code owner August 14, 2025 11:58

Sakilmostak added C-feature Category: Feature request or enhancement A-payment-methods Area: Payment Methods M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 14, 2025

hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Aug 14, 2025

prasunna09 and others added 4 commits August 17, 2025 21:42

fix clippy

8bff3db

chore: run formatter

24bd3ed

Merge branch 'add-confirm-proxy-flow' into saved_card_proxy

8c54d13

refactor: resolve ci checks

4bc7b07

jarnura requested changes Aug 18, 2025

View reviewed changes

crates/router/src/core/payments/operations/external_vault_proxy_payment_intent.rs Outdated Show resolved Hide resolved

refactor: resolve comments

ecef164

prasunna09 requested changes Aug 18, 2025

View reviewed changes

Base automatically changed from add-confirm-proxy-flow to main August 18, 2025 11:23

Sakilmostak added 4 commits August 18, 2025 18:56

Merge branch 'main' into saved_card_proxy

cf7506f

refactor: rebase with main

066915d

refactor: resolve comment

a66ea93

refactor: resolve ci checks

0726b1b

prasunna09 reviewed Aug 18, 2025

View reviewed changes

refactor: resolve ci checks

62e4ab2

prasunna09 previously approved these changes Aug 18, 2025

View reviewed changes

docs(openapi): re-generate OpenAPI specification

cff0890

hyperswitch-bot bot dismissed prasunna09’s stale review via cff0890 August 18, 2025 18:32

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 18, 2025

jarnura requested changes Aug 19, 2025

View reviewed changes

Sakilmostak and others added 4 commits August 19, 2025 21:43

refactor: resolve comments

952ad12

chore: run formatter

f976614

refactor: resolve comments

d469127

refactor: convert v2 to v1 in toml

d6eb9cc

jarnura approved these changes Aug 20, 2025

View reviewed changes

prasunna09 approved these changes Aug 20, 2025

View reviewed changes

Sakilmostak changed the title ~~feat(payment-methods): [Proxy] add saved card flow for proxy payemnts~~ feat(payment-methods): [Proxy] add saved card flow for proxy payments Aug 20, 2025

bernard-eugine added this pull request to the merge queue Aug 20, 2025

Merged via the queue into main with commit 73dfa5e Aug 20, 2025
25 of 29 checks passed

bernard-eugine deleted the saved_card_proxy branch August 20, 2025 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(payment-methods): [Proxy] add saved card flow for proxy payments#8964

feat(payment-methods): [Proxy] add saved card flow for proxy payments#8964
bernard-eugine merged 48 commits intomainfrom
saved_card_proxy

Sakilmostak commented Aug 14, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

prasunna09 Aug 18, 2025 •

edited

Loading

Uh oh!

prasunna09 Aug 18, 2025

Uh oh!

Sakilmostak Aug 18, 2025

Uh oh!

prasunna09 Aug 18, 2025

Uh oh!

Sakilmostak Aug 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prasunna09 Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Sakilmostak commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

prasunna09 Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prasunna09 Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Sakilmostak Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

prasunna09 Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Sakilmostak Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prasunna09 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sakilmostak commented Aug 14, 2025 •

edited

Loading

semanticdiff-com bot commented Aug 14, 2025 •

edited

Loading

prasunna09 Aug 18, 2025 •

edited

Loading