feat(connector): [BRAINTREE] Googlepay, Applepay wallets added#8728
Merged
Gnanasundari24 merged 14 commits intomainfrom Oct 7, 2025
Merged
feat(connector): [BRAINTREE] Googlepay, Applepay wallets added#8728Gnanasundari24 merged 14 commits intomainfrom
Gnanasundari24 merged 14 commits intomainfrom
Conversation
0142ee7 to
8f49cb0
Compare
cf97700 to
a438026
Compare
718b836 to
2428ff1
Compare
deepanshu-iiitu
requested changes
Aug 14, 2025
0cf3d8f to
462ec99
Compare
12f526e to
fcbeb6c
Compare
7b6c352 to
a9b5735
Compare
ShankarSinghC
previously approved these changes
Sep 26, 2025
deepanshu-iiitu
previously approved these changes
Sep 26, 2025
ShankarSinghC
previously approved these changes
Sep 29, 2025
deepanshu-iiitu
previously approved these changes
Sep 29, 2025
apoorvdixit88
previously approved these changes
Sep 29, 2025
Contributor
apoorvdixit88
left a comment
There was a problem hiding this comment.
Dashboard changes look fine.
jarnura
previously approved these changes
Oct 1, 2025
deepanshu-iiitu
approved these changes
Oct 3, 2025
ShankarSinghC
approved these changes
Oct 6, 2025
apoorvdixit88
approved these changes
Oct 6, 2025
Contributor
Author
|
To get session-token, we shouldn't use PMD in payment-intent call. This is because now the we have different logic for session-token (segregating core and connector layer). And if we use PMD in payment-intent (for connectors to form session-token in connector layer), that pmt will be given priority |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Googlepay,Applepaywallets added inBRAINTREE.In the current implementation of the session-token response flow, only the core layer logic is triggered for apple_pay and google_pay. However, for Braintree, we require a client_token generated from the connector layer.
To support this, I’ve added three new methods in ConnectorSpecifications:
These methods determine whether a connector supports session-token response for a specific payment_method_type. Based on this, mapping is being done whether the session-token should be formed in the core layer or the connector layer.
Additional Changes
Motivation and Context
How did you test it?
Currently, testing can be done S2S only, because SDK and dashboard are yet to be done.
1. MCA
Response:
PMD shouldn't be passed in payment-intent to fetch session-token for braintree. Ref
2. Session Token
Response:
3. Google pay
Response:
4. Apple pay
Response:
Test apple_pay, google_pay for other prod connectors (trustpay, stripe, cybersource).
Checklist
cargo +nightly fmt --allcargo clippy