feat(connector): [SILVERFLOW] Integrate cards non 3ds payments#8591
Merged
Gnanasundari24 merged 7 commits intomainfrom Jul 24, 2025
Merged
feat(connector): [SILVERFLOW] Integrate cards non 3ds payments#8591Gnanasundari24 merged 7 commits intomainfrom
Gnanasundari24 merged 7 commits intomainfrom
Conversation
|
Review changes with Changed Files
|
2 tasks
deepanshu-iiitu
requested changes
Jul 10, 2025
crates/hyperswitch_connectors/src/connectors/silverflow/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/silverflow/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/silverflow/transformers.rs
Outdated
Show resolved
Hide resolved
deepanshu-iiitu
requested changes
Jul 11, 2025
| #[derive(Default, Debug, Serialize, PartialEq)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct MerchantAcceptorResolver { | ||
| merchant_acceptor_key: String, |
Contributor
There was a problem hiding this comment.
What is the merchant acceptor key used for?
Should we fetch it from connector auth keys instead of metadata?
| // Basic structures for Silverflow API | ||
| #[derive(Default, Debug, Clone, Serialize, Deserialize, PartialEq)] | ||
| pub struct Amount { | ||
| value: i64, |
Contributor
There was a problem hiding this comment.
Amount.value should be of the type of MinorUnit here
| .into()), | ||
| PaymentMethodData::Card(req_card) => { | ||
| // Convert MinorUnit to i64 for amount value | ||
| let amount_value = item.amount.get_amount_as_i64(); |
Contributor
There was a problem hiding this comment.
Make amount_value field of type MinorUnit and then this conversion wont be needed
| pub struct SilverflowRefundRequest { | ||
| pub amount: StringMinorUnit, | ||
| #[serde(rename = "refundAmount")] | ||
| pub refund_amount: i64, |
Contributor
There was a problem hiding this comment.
Make refund_amount field as MinorUnit
Comment on lines
+518
to
+521
| let refund_amount_value = item.amount.get_amount_as_i64(); | ||
|
|
||
| Ok(Self { | ||
| amount: item.amount.to_owned(), | ||
| refund_amount: refund_amount_value, |
Contributor
There was a problem hiding this comment.
This conversion wont be needed when you make refund_amount field as MinorUnit
deepanshu-iiitu
previously approved these changes
Jul 14, 2025
deepanshu-iiitu
approved these changes
Jul 23, 2025
ShankarSinghC
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Cards Non-3DS payments added for silverflow (Alpha Integration).
Ref: https://www.silverflow.com/
Additional Changes
Motivation and Context
#8592
How did you test it?
Compilation and Clippy checks by cargo build and cargo clippy
No cypress due to Alpha integration.
Checklist
cargo +nightly fmt --allcargo clippy