feat(connector): [SANTANDER] Added Authorize, PSync, Void, Refund & RSync Flows for Pix QR Code Bank Transfer by bsayak03 · Pull Request #8463 · juspay/hyperswitch

bsayak03 · 2025-06-25T14:45:44Z

Type of Change

Description

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

Ref Doc : https://developer.santander.com.br/api/documentacao/pix-visao-geral#/api/documentacao/pix-visao-geral/
https://developer.santander.com.br/api/user-guide/pix-visao-geral

How did you test it?

This PR cannot be tested because we are still awaiting on creds

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-06-25T14:45:47Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/santander.rs	10% smaller
crates/hyperswitch_connectors/src/connectors/santander/transformers.rs	8% smaller
Cargo.lock	Unsupported file format
api-reference/v1/openapi_spec_v1.json	0% smaller
api-reference/v2/openapi_spec_v2.json	0% smaller
config/config.example.toml	Unsupported file format
config/deployments/integration_test.toml	Unsupported file format
config/deployments/production.toml	Unsupported file format
config/deployments/sandbox.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
crates/api_models/src/payments.rs	0% smaller
crates/common_enums/src/connector_enums.rs	0% smaller
crates/connector_configs/src/connector.rs	0% smaller
crates/connector_configs/toml/development.toml	Unsupported file format
crates/connector_configs/toml/production.toml	Unsupported file format
crates/connector_configs/toml/sandbox.toml	Unsupported file format
crates/hyperswitch_connectors/Cargo.toml	Unsupported file format
crates/payment_methods/src/configs/payment_connector_required_fields.rs	0% smaller
crates/router/src/core/admin.rs	0% smaller
crates/router/src/core/payments/transformers.rs	0% smaller
crates/router/src/types/api.rs	0% smaller
crates/router/src/types/transformers.rs	0% smaller
loadtest/config/development.toml	Unsupported file format

awasthi21 · 2025-06-27T19:11:01Z

crates/hyperswitch_connectors/src/connectors/santander.rs

+                router_data.request.integrity_object = Some(response_integrity_object);
+                router_data
+            })
+            .change_context(errors::ConnectorError::ResponseHandlingFailed)


Suggested fix (NIT)
Apply change_context before calling Map()
new_router_data
.change_context(errors::ConnectorError::ResponseHandlingFailed)
.map(|mut router_data| {
router_data.request.integrity_object = Some(response_integrity_object);
router_data
})

no map only works on Result and Options and once we do change_context the Result is unwrapped so we wont be able to use .map then

Result is not upwrapped unless you apply ?
.change_context(errors::ConnectorError::ResponseHandlingFailed)
will only change the error type. It will still be Result
.change_context() does NOT unwrap

Got it, made the relevant changes

awasthi21 · 2025-06-27T19:11:20Z

crates/hyperswitch_connectors/src/connectors/santander.rs

+                router_data.request.integrity_object = Some(response_integrity_object);
+                router_data
+            })
+            .change_context(errors::ConnectorError::ResponseHandlingFailed)


awasthi21 · 2025-06-27T19:12:14Z

crates/hyperswitch_connectors/src/connectors/santander.rs

+                router_data.request.integrity_object = Some(response_integrity_object);
+                router_data
+            })
+            .change_context(errors::ConnectorError::ResponseHandlingFailed)


awasthi21 · 2025-06-27T19:15:37Z

crates/hyperswitch_connectors/src/connectors/santander.rs

    ) -> CustomResult<String, errors::ConnectorError> {
-        Err(errors::ConnectorError::NotImplemented("get_url method".to_string()).into())
+        let connector_metadata = req.request.connector_metadata.clone();
+        let end_to_end_id = match &connector_metadata {


nit:
We can use .and_then() instead of nested match cases

awasthi21 · 2025-06-27T19:20:23Z

crates/hyperswitch_connectors/src/connectors/santander/transformers.rs

+pub struct SantanderValue {
+    pub original: StringMajorUnit,
+}
+


SantanderValue and SantanderValueResponse both are same structs
can we use a single struct instead

awasthi21 · 2025-06-27T19:26:58Z

crates/hyperswitch_domain_models/src/router_request_types.rs

    pub additional_payment_method_data: Option<AdditionalPaymentData>,
    pub merchant_account_id: Option<Secret<String>>,
    pub merchant_config_currency: Option<storage_enums::Currency>,
+    pub santander_pix_qr_expiration_time: Option<api_models::payments::SantanderBillingType>,


Can we confirm with core folks if we should be passing connector specific config here
@SanchithHegde

removing this

deepanshu-iiitu · 2025-06-30T07:04:56Z

Add test cases in PR description

bsayak03 · 2025-06-30T07:11:56Z

Add test cases in PR description

Cannot be tested because we are still awaiting on creds from Zurich team

crates/hyperswitch_connectors/src/utils.rs

crates/router/src/core/payments/transformers.rs

crates/hyperswitch_connectors/src/connectors/santander/transformers.rs

crates/payment_methods/src/configs/payment_connector_required_fields.rs

crates/router/src/core/admin.rs

Cargo.lock

SanchithHegde · 2025-07-01T18:35:33Z

crates/hyperswitch_connectors/Cargo.toml

 ]

 [dependencies]
+chrono = "0.4"


@bsayak03 @awasthi21 Prefer to use the time crate over chrono since we're using it everywhere else in our codebase...

sure, i'll replace it in the next PR

bsayak03 requested review from a team as code owners June 25, 2025 14:45

bsayak03 self-assigned this Jun 25, 2025

bsayak03 closed this Jun 25, 2025

bsayak03 force-pushed the santander/pix-qr branch from 80eb4d9 to 0a06ad9 Compare June 25, 2025 14:52

feat(connector): Added Pix QR Code Bank Transfer

b5c9773

bsayak03 reopened this Jun 25, 2025

hyperswitch-bot bot and others added 2 commits June 25, 2025 14:57

chore: run formatter

b8a0563

fix: resolved open_api_spec errors

9ca89c6

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jun 26, 2025

Merge branch 'main' into santander/pix-qr

bc07210

awasthi21 reviewed Jun 27, 2025

View reviewed changes

deepanshu-iiitu requested changes Jun 30, 2025

View reviewed changes

crates/hyperswitch_connectors/src/utils.rs Outdated Show resolved Hide resolved

crates/router/src/core/payments/transformers.rs Outdated Show resolved Hide resolved

crates/hyperswitch_connectors/src/connectors/santander/transformers.rs Outdated Show resolved Hide resolved

Sayak Bhattacharya added 3 commits June 30, 2025 13:10

fix: resolved pr comments and added country currency in config files

d5b8603

fix: resolved pr comments

66d9973

fix: resolved PR comments

2797e20

bsayak03 requested a review from a team as a code owner June 30, 2025 12:36

deepanshu-iiitu requested changes Jun 30, 2025

View reviewed changes

crates/payment_methods/src/configs/payment_connector_required_fields.rs Outdated Show resolved Hide resolved

Sayak Bhattacharya added 2 commits July 1, 2025 11:07

fix: resolved PR comments

1ffacbd

fix: resolved PR comments

047a259

deepanshu-iiitu requested changes Jul 1, 2025

View reviewed changes

crates/router/src/core/admin.rs Outdated Show resolved Hide resolved

fix: resolved PR comments

9e48ae8

deepanshu-iiitu previously approved these changes Jul 1, 2025

View reviewed changes

deepanshu-iiitu removed the request for review from a team July 1, 2025 08:51

Chethan-rao reviewed Jul 1, 2025

View reviewed changes

Cargo.lock Show resolved Hide resolved

Chethan-rao previously approved these changes Jul 1, 2025

View reviewed changes

AnuthaDev previously approved these changes Jul 1, 2025

View reviewed changes

feat(wasm): added configs for control center

b4373fd

bsayak03 dismissed stale reviews from AnuthaDev, Chethan-rao, and deepanshu-iiitu via b4373fd July 1, 2025 10:21

deepanshu-iiitu approved these changes Jul 1, 2025

View reviewed changes

AnuthaDev approved these changes Jul 1, 2025

View reviewed changes

Chethan-rao approved these changes Jul 1, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Jul 1, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2025

likhinbopanna added this pull request to the merge queue Jul 1, 2025

Merged via the queue into main with commit 28d6357 Jul 1, 2025
17 of 20 checks passed

likhinbopanna deleted the santander/pix-qr branch July 1, 2025 14:51

SanchithHegde reviewed Jul 1, 2025

View reviewed changes

Conversation

bsayak03 commented Jun 25, 2025 • edited by deepanshu-iiitu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepanshu-iiitu commented Jun 30, 2025

Uh oh!

bsayak03 commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bsayak03 Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bsayak03 commented Jun 25, 2025 •

edited by deepanshu-iiitu

Loading

semanticdiff-com bot commented Jun 25, 2025 •

edited

Loading

bsayak03 Jul 3, 2025 •

edited

Loading