fix(connector): adyen connector creates connector's customer reference on the fly fixed#8447
Merged
likhinbopanna merged 3 commits intomainfrom Jun 24, 2025
Merged
fix(connector): adyen connector creates connector's customer reference on the fly fixed#8447likhinbopanna merged 3 commits intomainfrom
likhinbopanna merged 3 commits intomainfrom
Conversation
|
Review changes with Changed Files
|
kashif-m
requested changes
Jun 24, 2025
Contributor
kashif-m
left a comment
There was a problem hiding this comment.
Looks good, let's update this field in other environments too
2 tasks
kashif-m
previously approved these changes
Jun 24, 2025
Contributor
kashif-m
left a comment
There was a problem hiding this comment.
nit - list can be in alphabetical order
kashif-m
approved these changes
Jun 24, 2025
Chethan-rao
approved these changes
Jun 24, 2025
| ) -> Result<RecurringDetails, Error> { | ||
| match (item.request.setup_future_usage, item.request.off_session) { | ||
| (Some(storage_enums::FutureUsage::OffSession), _) => { | ||
| let shopper_reference = match item.get_connector_customer_id() { |
Contributor
There was a problem hiding this comment.
Nit-Pick: Can you use build_shopper_reference() here
AkshayaFoiger
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adyen now uses
connector_customer_idto formshopper_referenceif the field is present, else falls to previous implementation.Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy