feat(connector): Add dummy billing connector auth flow#7819
Merged
Gnanasundari24 merged 14 commits intomainfrom Apr 23, 2025
Merged
feat(connector): Add dummy billing connector auth flow#7819Gnanasundari24 merged 14 commits intomainfrom
Gnanasundari24 merged 14 commits intomainfrom
Conversation
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Following are the paths where you can find config files: 1. `config` 2. `crates/router/src/configs` 3. `loadtest/config` --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implementation (unless it is an obvious bug or documentation fix that will have little conversation). --> ## How did you test it? <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)? --> ## Checklist <!-- Put an `x` in the boxes that apply --> - [ ] I formatted the code `cargo +nightly fmt --all` - [ ] I addressed lints thrown by `cargo clippy` - [ ] I reviewed the submitted code - [ ] I added unit tests for my changes where possible
|
Review changes with Changed Files
|
srujanchikke
requested changes
Apr 16, 2025
| } | ||
| pub fn is_separate_authentication_supported(self) -> bool { | ||
| match self { | ||
| Self::DummyBillingConnector => false, |
Contributor
There was a problem hiding this comment.
move it under feature flag
Member
Author
There was a problem hiding this comment.
i have moved it in under feature flag
| pub mod deutschebank; | ||
| pub mod digitalvirgo; | ||
| pub mod dlocal; | ||
| pub mod dummybillingconnector; |
Contributor
There was a problem hiding this comment.
Do we need this in hyperswitch_connectors ? If not we can remove changes in hyperswitch_connectors, connectors, and Connector enums.
crates/router/src/core/admin.rs
Outdated
Comment on lines
+1247
to
+1250
| api_enums::Connector::DummyBillingConnector => { | ||
| dummyconnector::transformers::DummyConnectorAuthType::try_from(self.auth_type)?; | ||
| Ok(()) | ||
| } |
Contributor
There was a problem hiding this comment.
you can write similar logic which is already existed for DummyConnectors
crates/router/src/connector.rs
Outdated
Comment on lines
+3
to
+4
| pub mod dummybillingconnector; | ||
| #[cfg(feature = "dummy_connector")] |
Contributor
There was a problem hiding this comment.
Is this required, can we not remove just like we have removed it it hyperswitch_connectors ?
srujanchikke
approved these changes
Apr 21, 2025
jarnura
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added a dummy billing connector whose conector type is billing processor to support recovery flow.
Additional Changes
Motivation and Context
How did you test it?
cURL request:-
Response:-
Checklist
cargo +nightly fmt --allcargo clippy