Skip to content

feat(core): Adds Billing Connector Invoice Sync flow in Revenue Recovery#7799

Merged
likhinbopanna merged 7 commits intomainfrom
billing_connector_invoice_psync_call
Apr 29, 2025
Merged

feat(core): Adds Billing Connector Invoice Sync flow in Revenue Recovery#7799
likhinbopanna merged 7 commits intomainfrom
billing_connector_invoice_psync_call

Conversation

@NISHANTH1221
Copy link
Contributor

@NISHANTH1221 NISHANTH1221 commented Apr 11, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds billing connector invoice sync flow to revenue recovery. This is used to fetch invoice details from billing connectors. There is some invoice related information which are needed for revenue recovery system but our current flow is not enough for it. This PR just adds BIllingConnectorInvoiceSync Flow to RevenueRecovery.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

For Revenue Recovery Transaction Monitoring : In case of Recurly a billing connector, we need details such as retry_count which we wont get this through BillingConnectorPaymentSyncCall or webhook. To accommodate such things we need Invoice sync flow.

How did you test it?

No testing needed since this is just a definition of flow

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@NISHANTH1221 NISHANTH1221 self-assigned this Apr 11, 2025
@NISHANTH1221 NISHANTH1221 requested review from a team as code owners April 11, 2025 13:17
@semanticdiff-com
Copy link

semanticdiff-com bot commented Apr 11, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/types.rs  90% smaller
  crates/router/src/types/api.rs  86% smaller
  crates/hyperswitch_domain_models/src/types.rs  58% smaller
  crates/hyperswitch_interfaces/src/api/revenue_recovery.rs  54% smaller
  crates/hyperswitch_interfaces/src/api/revenue_recovery_v2.rs  54% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  54% smaller
  crates/hyperswitch_interfaces/src/types.rs  48% smaller
  crates/router/src/core/payments/flows.rs  1% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_data_v2/flow_common_types.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_flow_types/revenue_recovery.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_response_types/revenue_recovery.rs  0% smaller
  crates/router/src/services/api.rs  0% smaller

@NISHANTH1221 NISHANTH1221 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 11, 2025
srujanchikke
srujanchikke previously approved these changes Apr 22, 2025
View reviewed changes
ShankarSinghC
ShankarSinghC previously approved these changes Apr 24, 2025
View reviewed changes
@NISHANTH1221 NISHANTH1221 removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 24, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2025
@NISHANTH1221 NISHANTH1221 dismissed stale reviews from srujanchikke and ShankarSinghC via 23ed82c April 28, 2025 12:11
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit 3d0dd5b Apr 29, 2025
16 of 20 checks passed
@likhinbopanna likhinbopanna deleted the billing_connector_invoice_psync_call branch April 29, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@NISHANTH1221 NISHANTH1221

Labels

A-core Area: Core flows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NISHANTH1221 @ShankarSinghC @srujanchikke @likhinbopanna