Skip to content

feat(connector): Add record back connector integration flow #7416

Merged
likhinbopanna merged 17 commits intomainfrom
recovery_record_back_flow
Mar 12, 2025
Merged

feat(connector): Add record back connector integration flow #7416
likhinbopanna merged 17 commits intomainfrom
recovery_record_back_flow

Conversation

@srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Mar 4, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

After passive churn recovery retries the payment, we will have to record back and update the invoice in billing process. This PR adds support for this by adding connector integration flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Testing not required since this just add flow to the connector integration and doesn't implemented for any connector.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com
Copy link

semanticdiff-com bot commented Mar 4, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/types.rs  94% smaller
  crates/hyperswitch_domain_models/src/types.rs  76% smaller
  crates/hyperswitch_interfaces/src/types.rs  60% smaller
  crates/hyperswitch_interfaces/src/api/revenue_recovery.rs  55% smaller
  crates/hyperswitch_interfaces/src/api/revenue_recovery_v2.rs  49% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  14% smaller
  crates/router/src/core/payments/flows.rs  3% smaller
  crates/hyperswitch_domain_models/src/router_data_v2/flow_common_types.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_flow_types/revenue_recovery.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_response_types/revenue_recovery.rs  0% smaller
  crates/router/src/services/api.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller

@srujanchikke srujanchikke self-assigned this Mar 8, 2025
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration api-v2 A-core Area: Core flows labels Mar 8, 2025
@srujanchikke srujanchikke changed the title add record back connector integration flow feat(connector): Add record back connector integration flow Mar 8, 2025
@srujanchikke srujanchikke marked this pull request as ready for review March 8, 2025 13:34
@srujanchikke srujanchikke requested review from a team as code owners March 8, 2025 13:34
Sakilmostak
Sakilmostak previously approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@Sakilmostak Sakilmostak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ShankarSinghC
ShankarSinghC reviewed Mar 10, 2025
View reviewed changes
crates/hyperswitch_interfaces/src/types.rs Outdated
UasAuthenticationResponseData,
>;

/// Type alias for `ConnectorIntegration<RevenueRecoveryRecordBack, RevenueRecoveryRecordBackRequest, RevenueRecoveryRecordBackResponse>`
Copy link
Contributor

@ShankarSinghC ShankarSinghC Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
/// Type alias for `ConnectorIntegration<RevenueRecoveryRecordBack, RevenueRecoveryRecordBackRequest, RevenueRecoveryRecordBackResponse>`
/// Type alias for `ConnectorIntegration<RevenueRecoveryRecordBackFlow, RevenueRecoveryRecordBackRequest, RevenueRecoveryRecordBackResponse>`

@likhinbopanna likhinbopanna enabled auto-merge March 12, 2025 08:02
@likhinbopanna likhinbopanna added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit 13a2749 Mar 12, 2025
15 of 20 checks passed
@likhinbopanna likhinbopanna deleted the recovery_record_back_flow branch March 12, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sakilmostak Sakilmostak Sakilmostak approved these changes

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

Assignees

@srujanchikke srujanchikke

Labels

A-connector-integration Area: Connector integration A-core Area: Core flows api-v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srujanchikke @Sakilmostak @ShankarSinghC @likhinbopanna