Skip to content

feat(router): add merchant_configuration_id in netcetera metadata and make other merchant configurations optional#7348

Merged
SanchithHegde merged 3 commits intohotfix-2025.02.10.0from
netcetera-merchant-configuration-hotfix
Feb 21, 2025
Merged

feat(router): add merchant_configuration_id in netcetera metadata and make other merchant configurations optional#7348
SanchithHegde merged 3 commits intohotfix-2025.02.10.0from
netcetera-merchant-configuration-hotfix

Conversation

@sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Feb 21, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add merchant_configuration_id in netcetera metadata and make other merchant configurations optional

Main PR - #7347

Clippy Successful Locally
image

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

test cases in main PR

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes labels Feb 21, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Feb 21, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners February 21, 2025 14:54
@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 21, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/netcetera/transformers.rs  62% smaller
  crates/router/src/core/payments/helpers.rs  55% smaller
  crates/connector_configs/src/common_config.rs  0% smaller
  crates/connector_configs/src/connector.rs  0% smaller
  crates/connector_configs/toml/development.toml Unsupported file format
  crates/connector_configs/toml/production.toml Unsupported file format
  crates/connector_configs/toml/sandbox.toml Unsupported file format
  crates/router/src/core/payments/operations/payment_confirm.rs  0% smaller

ShankarSinghC
ShankarSinghC previously approved these changes Feb 21, 2025
View reviewed changes
@SanchithHegde SanchithHegde merged commit 2515d75 into hotfix-2025.02.10.0 Feb 21, 2025
11 of 21 checks passed
@SanchithHegde SanchithHegde deleted the netcetera-merchant-configuration-hotfix branch February 21, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels

A-core Area: Core flows C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes

Projects

None yet

Milestone

February 2025 Release

Development

Successfully merging this pull request may close these issues.

5 participants

@sai-harsha-vardhan @ShankarSinghC @swangi-kumari @JeevaRamu0104 @SanchithHegde