refactor(core): add support for expand attempt list in psync v2#7209
Merged
likhinbopanna merged 14 commits intomainfrom Feb 11, 2025
Merged
refactor(core): add support for expand attempt list in psync v2#7209likhinbopanna merged 14 commits intomainfrom
likhinbopanna merged 14 commits intomainfrom
Conversation
Changed Files
|
jarnura
previously approved these changes
Feb 10, 2025
| }) | ||
| .async_and_then(|payment_attempts| async { | ||
| let mut domain_payment_attempts = Vec::with_capacity(payment_attempts.len()); | ||
| for attempt in payment_attempts.into_iter() { |
Contributor
There was a problem hiding this comment.
@dracarys18 is the feature to decrypt multiple entities of the same merchant available in the key manager?
Contributor
There was a problem hiding this comment.
Not yet, it's an open PR
Narayanbhat166
approved these changes
Feb 11, 2025
jarnura
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
We have expand attempts list in v1 payment sync response which is used by dashboard team. We need similar support in v2. By passing expand_attempts in psync query param, vector of payment attempts associated with the intent will be returned in the payments get response.
Additional Changes
Motivation and Context
How did you test it?
Create payment intent and confirm the payment intent
Test case 1 : pass expand_attempts=true in payment get api
Response :
TestCase 2 : pass exapand_attemps = false or don't pass it in the query params, This should make attempts field in the response to null.
Checklist
cargo +nightly fmt --allcargo clippy