feat(routing): build the gRPC interface for communicating with the external service to perform elimination routing#6672
Merged
likhinbopanna merged 17 commits intomainfrom Dec 13, 2024
Conversation
|
Review changes with Changed Files
|
Chethan-rao
previously approved these changes
Nov 27, 2024
Chethan-rao
reviewed
Nov 27, 2024
Co-authored-by: Chethan Rao <70657455+Chethan-rao@users.noreply.github.com>
…mination-routing-interface
…spay/hyperswitch into elimination-routing-interface
Chethan-rao
suggested changes
Dec 6, 2024
| field: "bucket_size".to_string(), | ||
| })?, | ||
| bucket_leak_interval_in_secs: config | ||
| .bucket_ttl_in_mins |
Contributor
There was a problem hiding this comment.
could u rename this too?
…mination-routing-interface
Contributor
|
please add test cases to all 3 endpoints and check the validations too |
Chethan-rao
approved these changes
Dec 6, 2024
NishantJoshi00
approved these changes
Dec 9, 2024
Contributor
+1 on that. It would be better to have test cases. attached showing an example execution of these functionality. |
Contributor
Author
Okay sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
build the gRPC interface for communicating with the external service to perform elimination routing
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy