fix(analytics): fix refund status filter on dashboard#6431
Merged
likhinbopanna merged 1 commit intomainfrom Oct 25, 2024
Merged
fix(analytics): fix refund status filter on dashboard#6431likhinbopanna merged 1 commit intomainfrom
likhinbopanna merged 1 commit intomainfrom
Conversation
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 50% smaller than the GitHub diff.
|
su-shivanshmathur
approved these changes
Oct 24, 2024
lsampras
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refund Statusfilter is applied on the analytics section on dashboard, errors are being generated.RefundStatusenum has been imported for theRefundStatusfilter inRefundFiltersstruct in this PR: feat(analytics): Add Clickhouse based analytics #2988.RefundStatusimport.Additional Changes
Motivation and Context
To fix the issue on dashboard whenever refund status filter is applied.
How did you test it?
Apply the refund status filter on the dashboard
Hit the curl:
Respoonse:
{ "queryData": [ { "refund_success_rate": 100.0, "refund_count": 1, "refund_success_count": 1, "refund_processed_amount": 600, "currency": null, "refund_status": null, "connector": null, "refund_type": null, "profile_id": null, "time_range": { "start_time": "2024-10-24T00:00:00.000Z", "end_time": "2024-10-24T23:00:00.000Z" }, "time_bucket": "2024-10-24 00:00:00" } ], "metaData": [ { "current_time_range": { "start_time": "2024-10-16T18:30:00.000Z", "end_time": "2024-10-24T13:17:00.000Z" } } ] }Checklist
cargo +nightly fmt --allcargo clippy