refactor(connector): added amount conversion to FISERV#6256
Closed
ravikiran232 wants to merge 3 commits intojuspay:mainfrom
Closed
refactor(connector): added amount conversion to FISERV#6256ravikiran232 wants to merge 3 commits intojuspay:mainfrom
ravikiran232 wants to merge 3 commits intojuspay:mainfrom
Conversation
|
Review changes with SemanticDiff. Analyzed 5 of 5 files. Overall, the semantic diff is 33% smaller than the GitHub diff.
|
deepanshu-iiitu
requested changes
Oct 17, 2024
| .into() | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
Please remove this
Contributor
|
@ravikiran232 Please implement the suggested changes. |
Contributor
|
Hey @ravikiran232 Any updates on the changes! |
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
added MinorUnit for amount conversion
Additional Changes
Motivation and Context
fixes #5947
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy