Skip to content

feat(analytics): Add card network filter#6087

Merged
likhinbopanna merged 3 commits intomainfrom
add_card_network_filter
Sep 26, 2024
Merged

feat(analytics): Add card network filter#6087
likhinbopanna merged 3 commits intomainfrom
add_card_network_filter

Conversation

@lsampras
Copy link
Contributor

@lsampras lsampras commented Sep 25, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add card network analytics filter in payment analytics

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@lsampras lsampras added C-feature Category: Feature request or enhancement A-Analytics labels Sep 25, 2024
@lsampras lsampras self-assigned this Sep 25, 2024
@lsampras lsampras requested a review from a team as a code owner September 25, 2024 20:51
@semanticdiff-com
Copy link

semanticdiff-com bot commented Sep 25, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 6 of 6 files.

Overall, the semantic diff is 17% smaller than the GitHub diff.

Filename Status
✔️ crates/api_models/src/analytics/payments.rs 47.7% smaller
✔️ crates/analytics/src/opensearch.rs 65.0% smaller
✔️ crates/analytics/src/sqlx.rs Analyzed
✔️ crates/analytics/src/payments/core.rs Analyzed
✔️ crates/analytics/src/payments/filters.rs Analyzed
✔️ crates/analytics/src/payments/types.rs Analyzed

@lsampras lsampras linked an issue Sep 25, 2024 that may be closed by this pull request
feat(analytics): add card network feature #6086
Closed
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 8049993 Sep 26, 2024
@likhinbopanna likhinbopanna deleted the add_card_network_filter branch September 26, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsdk02 tsdk02 tsdk02 approved these changes

+1 more reviewer

@dracarys18 dracarys18 dracarys18 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lsampras lsampras

Labels

A-Analytics C-feature Category: Feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(analytics): add card network feature

4 participants

@lsampras @dracarys18 @tsdk02 @likhinbopanna