Skip to content

feat(connector): [Novalnet] add Payment flows for cards#5726

Merged
likhinbopanna merged 22 commits intomainfrom
novalnetFlow
Sep 12, 2024
Merged

feat(connector): [Novalnet] add Payment flows for cards#5726
likhinbopanna merged 22 commits intomainfrom
novalnetFlow

Conversation

@dgeee13
Copy link
Contributor

@dgeee13 dgeee13 commented Aug 27, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Integrate card payments for new connector Novalnet
https://developer.novalnet.com/onlinepayments/api

(3DS flow is tested and working fine, no3DS flow is not yet working.)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/6617

How did you test it?

Cypress test:

Test passes for
1) 3DS AutoCapture
Screenshot 2024-09-11 at 17 13 23
2) 3DS ManualCapture
Screenshot 2024-09-11 at 17 12 52
3)3DS Refund flow
Screenshot 2024-09-11 at 17 16 24

Test cases failing for
1. Void (no3DS flow)
2. Refund (no3DS flow)
3. Sync (no3DS flow)

(Test cases will be passing once no3DS flow is fixed) @Gnanasundari24

Following flows need to be tested for card payments for new connector Novalnet:
1. Authorize

  • Request
{
    "amount": 10000,
    "currency": "EUR",
    "confirm": true,
    "payment_link": false,
    "capture_method": "manual",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 10000,
    "customer_id": "StripeCustomer",
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "three_ds",
    "return_url": "https://google.com",
    "payment_method": "card",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "4000 0000 0000 1091",
            "card_exp_month": "12",
            "card_exp_year": "2025",
            "card_holder_name": "Max Mustermann",
            "card_cvc": "123"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "CA",
            "line3": "CA",
            "city": "Musterhausen",
            "state": "California",
            "zip": "12345",
            "country": "DE",
            "first_name": "Max",
            "last_name": "Mustermann"
        },
        "email": "test@novalnet.de",
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "shipping": {
        "address": {
            "line1": "Musterstr",
            "line2": "CA",
            "line3": "CA",
            "city": "Musterhausen",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "browser_info": {
        "user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
        "accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,\/;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "ip_address": "103.77.139.95",
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}
  • Response
{
    "payment_id": "pay_ozb6BIL9ZFZfxGRZUNUz",
    "merchant_id": "merchant_1725360101",
    "status": "requires_customer_action",
    "amount": 10000,
    "net_amount": 10000,
    "amount_capturable": 10000,
    "amount_received": null,
    "connector": "novalnet",
    "client_secret": "pay_ozb6BIL9ZFZfxGRZUNUz_secret_BJxNPg7AMnNBzz647vi7",
    "created": "2024-09-06T10:36:36.100Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1091",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "400000",
            "card_extended_bin": null,
            "card_exp_month": "12",
            "card_exp_year": "2025",
            "card_holder_name": null,
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "Musterhausen",
            "country": "DE",
            "line1": "Musterstr",
            "line2": "CA",
            "line3": "CA",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "Musterhausen",
            "country": "DE",
            "line1": "1467",
            "line2": "CA",
            "line3": "CA",
            "zip": "12345",
            "state": "California",
            "first_name": "Max",
            "last_name": "Mustermann"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "test@novalnet.de"
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://google.com/",
    "authentication_type": "three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_ozb6BIL9ZFZfxGRZUNUz/merchant_1725360101/pay_ozb6BIL9ZFZfxGRZUNUz_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer",
        "created_at": 1725618995,
        "expires": 1725622595,
        "secret": "epk_01ca18ca46af49cd9aab9dccfe57ee1e"
    },
    "manual_retry_allowed": null,
    "connector_transaction_id": null,
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_HkRcE679QjhQHKHTEi1E",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_84zEkhY69OB3zMJQcVa0",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-09-06T10:51:36.099Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "103.77.139.95",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,/;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-09-06T10:36:37.752Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null
}

2. Capture

  • Request:
{
  "amount_to_capture": 10000,
  "statement_descriptor_name": "Joseph",
  "statement_descriptor_suffix": "JS"
}
  • Response:
{
   "payment_id": "pay_ozb6BIL9ZFZfxGRZUNUz",
   "merchant_id": "merchant_1725360101",
   "status": "succeeded",
   "amount": 10000,
   "net_amount": 10000,
   "amount_capturable": 0,
   "amount_received": 10000,
   "connector": "novalnet",
   "client_secret": "pay_ozb6BIL9ZFZfxGRZUNUz_secret_BJxNPg7AMnNBzz647vi7",
   "created": "2024-09-06T10:36:36.100Z",
   "currency": "EUR",
   "customer_id": "StripeCustomer",
   "customer": {
       "id": "StripeCustomer",
       "name": "John Doe",
       "email": "guest@example.com",
       "phone": "999999999",
       "phone_country_code": "+1"
   },
   "description": "Its my first payment request",
   "refunds": null,
   "disputes": null,
   "mandate_id": null,
   "mandate_data": null,
   "setup_future_usage": null,
   "off_session": null,
   "capture_on": null,
   "capture_method": "manual",
   "payment_method": "card",
   "payment_method_data": {
       "card": {
           "last4": "1091",
           "card_type": null,
           "card_network": null,
           "card_issuer": null,
           "card_issuing_country": null,
           "card_isin": "400000",
           "card_extended_bin": null,
           "card_exp_month": "12",
           "card_exp_year": "2025",
           "card_holder_name": null,
           "payment_checks": null,
           "authentication_data": null
       },
       "billing": null
   },
   "payment_token": null,
   "shipping": {
       "address": {
           "city": "Musterhausen",
           "country": "DE",
           "line1": "Musterstr",
           "line2": "CA",
           "line3": "CA",
           "zip": "94122",
           "state": "California",
           "first_name": "joseph",
           "last_name": "Doe"
       },
       "phone": {
           "number": "8056594427",
           "country_code": "+91"
       },
       "email": null
   },
   "billing": {
       "address": {
           "city": "Musterhausen",
           "country": "DE",
           "line1": "1467",
           "line2": "CA",
           "line3": "CA",
           "zip": "12345",
           "state": "California",
           "first_name": "Max",
           "last_name": "Mustermann"
       },
       "phone": {
           "number": "8056594427",
           "country_code": "+91"
       },
       "email": "test@novalnet.de"
   },
   "order_details": null,
   "email": "guest@example.com",
   "name": "John Doe",
   "phone": "999999999",
   "return_url": "https://google.com/",
   "authentication_type": "three_ds",
   "statement_descriptor_name": "joseph",
   "statement_descriptor_suffix": "JS",
   "next_action": null,
   "cancellation_reason": null,
   "error_code": null,
   "error_message": null,
   "unified_code": null,
   "unified_message": null,
   "payment_experience": null,
   "payment_method_type": "credit",
   "connector_label": null,
   "business_country": null,
   "business_label": "default",
   "business_sub_label": null,
   "allowed_payment_method_types": null,
   "ephemeral_key": null,
   "manual_retry_allowed": false,
   "connector_transaction_id": "15031000031803986",
   "frm_message": null,
   "metadata": {
       "udf1": "value1",
       "login_date": "2019-09-10T10:11:12Z",
       "new_customer": "true"
   },
   "connector_metadata": null,
   "feature_metadata": null,
   "reference_id": "15031000031803986",
   "payment_link": null,
   "profile_id": "pro_HkRcE679QjhQHKHTEi1E",
   "surcharge_details": null,
   "attempt_count": 1,
   "merchant_decision": null,
   "merchant_connector_id": "mca_84zEkhY69OB3zMJQcVa0",
   "incremental_authorization_allowed": null,
   "authorization_count": null,
   "incremental_authorizations": null,
   "external_authentication_details": null,
   "external_3ds_authentication_attempted": false,
   "expires_on": "2024-09-06T10:51:36.099Z",
   "fingerprint": null,
   "browser_info": {
       "language": "nl-NL",
       "time_zone": 0,
       "ip_address": "103.77.139.95",
       "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
       "color_depth": 24,
       "java_enabled": true,
       "screen_width": 1536,
       "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,/;q=0.8",
       "screen_height": 723,
       "java_script_enabled": true
   },
   "payment_method_id": null,
   "payment_method_status": null,
   "updated": "2024-09-06T10:39:31.242Z",
   "charges": null,
   "frm_metadata": null,
   "merchant_order_reference_id": null
}

3. Refund

  • Request:
{
  "payment_id": "pay_ozb6BIL9ZFZfxGRZUNUz",
  "amount": 100,
  "reason": "Customer returned product",
  "refund_type": "instant",
  "metadata": {
    "udf1": "value1",
    "new_customer": "true",
    "login_date": "2019-09-10T10:11:12Z"
  }
}
  • Response:
{
    "refund_id": "ref_IaORbLhcweHBNIvYMJq3",
    "payment_id": "pay_ozb6BIL9ZFZfxGRZUNUz",
    "amount": 100,
    "currency": "EUR",
    "status": "succeeded",
    "reason": "Customer returned product",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "error_message": null,
    "error_code": null,
    "created_at": "2024-09-06T10:40:13.381Z",
    "updated_at": "2024-09-06T10:40:17.101Z",
    "connector": "novalnet",
    "profile_id": "pro_HkRcE679QjhQHKHTEi1E",
    "merchant_connector_id": "mca_84zEkhY69OB3zMJQcVa0",
    "charges": null
}

4. Rsync

  • Response:
{
    "refund_id": "ref_IaORbLhcweHBNIvYMJq3",
    "payment_id": "pay_ozb6BIL9ZFZfxGRZUNUz",
    "amount": 100,
    "currency": "EUR",
    "status": "succeeded",
    "reason": "Customer returned product",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "error_message": null,
    "error_code": null,
    "created_at": "2024-09-06T10:40:13.381Z",
    "updated_at": "2024-09-06T10:40:46.082Z",
    "connector": "novalnet",
    "profile_id": "pro_HkRcE679QjhQHKHTEi1E",
    "merchant_connector_id": "mca_84zEkhY69OB3zMJQcVa0",
    "charges": null
}

5. Cancel

  • Request:
{
  "amount_to_capture": 100,
  "statement_descriptor_name": "Joseph",
  "statement_descriptor_suffix": "JS"
}
  • Response:
{
    "payment_id": "pay_rlrrE5bIq3BdfHITM2nN",
    "merchant_id": "merchant_1725360101",
    "status": "cancelled",
    "amount": 10000,
    "net_amount": 10000,
    "amount_capturable": 10000,
    "amount_received": null,
    "connector": "novalnet",
    "client_secret": "pay_rlrrE5bIq3BdfHITM2nN_secret_I2135mkB9sY3Qb0mQSCI",
    "created": "2024-09-06T10:41:36.242Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1091",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "400000",
            "card_extended_bin": null,
            "card_exp_month": "12",
            "card_exp_year": "2025",
            "card_holder_name": null,
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "Musterhausen",
            "country": "DE",
            "line1": "Musterstr",
            "line2": "CA",
            "line3": "CA",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "Musterhausen",
            "country": "DE",
            "line1": "1467",
            "line2": "CA",
            "line3": "CA",
            "zip": "12345",
            "state": "California",
            "first_name": "Max",
            "last_name": "Mustermann"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "test@novalnet.de"
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://google.com/",
    "authentication_type": "three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": null,
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_HkRcE679QjhQHKHTEi1E",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_84zEkhY69OB3zMJQcVa0",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-09-06T10:56:36.242Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "103.77.139.95",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,/;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-09-06T10:42:04.837Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@dgeee13 dgeee13 requested review from a team as code owners August 27, 2024 14:19
@semanticdiff-com
Copy link

semanticdiff-com bot commented Aug 27, 2024

Review changes with SemanticDiff.

Analyzed 18 of 24 files.

Overall, the semantic diff is 7% smaller than the GitHub diff.

1 files do not contain logic changes.

File Information
Filename Status
Cargo.lock Unsupported file format
✔️ cypress-tests/cypress/support/redirectionHandler.js 1.17% smaller
✔️ cypress-tests/cypress/e2e/PaymentUtils/Commons.js No logic changes found
cypress-tests/cypress/e2e/PaymentUtils/Novalnet.js Unsupported file format
✔️ cypress-tests/cypress/e2e/PaymentUtils/Utils.js Analyzed
✔️ crates/router/src/types/api.rs Analyzed
✔️ crates/router/src/types/transformers.rs Analyzed
✔️ crates/router/src/services/api.rs Analyzed
✔️ crates/router/src/core/admin.rs Analyzed
✔️ crates/router/src/configs/defaults.rs Analyzed
crates/hyperswitch_connectors/Cargo.toml Unsupported file format
✔️ crates/hyperswitch_connectors/src/constants.rs Analyzed
✔️ crates/hyperswitch_connectors/src/default_implementations.rs 16.0% smaller
✔️ crates/hyperswitch_connectors/src/utils.rs Analyzed
✔️ crates/hyperswitch_connectors/src/connectors/novalnet.rs 4.51% smaller
✔️ crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs 10.3% smaller
crates/connector_configs/toml/development.toml Unsupported file format
crates/connector_configs/toml/production.toml Unsupported file format
crates/connector_configs/toml/sandbox.toml Unsupported file format
✔️ crates/connector_configs/src/connector.rs Analyzed
✔️ crates/common_enums/src/enums.rs Analyzed
✔️ crates/api_models/src/enums.rs 8.33% smaller
✔️ api-reference-v2/openapi_spec.json Analyzed
✔️ api-reference/openapi_spec.json Analyzed

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 27, 2024
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 27, 2024
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 28, 2024
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 28, 2024
@srujanchikke srujanchikke changed the title add authorize flow and capture flow feat(connector): [Novalnet]add authorize flow and capture flow Sep 3, 2024
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 3, 2024
@dgeee13 dgeee13 requested review from a team as code owners September 4, 2024 10:58
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Sep 4, 2024
@hyperswitch-bot hyperswitch-bot bot removed the M-database-changes Metadata: This PR involves database schema changes label Sep 4, 2024
@dgeee13 dgeee13 force-pushed the novalnetFlow branch 2 times, most recently from e0040dc to c12a733 Compare September 4, 2024 15:47
@dgeee13 dgeee13 changed the title feat(connector): [Novalnet]add authorize flow and capture flow feat(connector): [Novalnet]add flows Sep 4, 2024
@dgeee13
Copy link
Contributor Author

dgeee13 commented Sep 11, 2024

@Gnanasundari24 I am getting some error while running cypress tests for the redirection flow (three ds auto capture), can we skip it and please merge this PR if all looks good for the time being?

CC: @srujanchikke @pranav-arjunan

SanchithHegde
SanchithHegde previously approved these changes Sep 11, 2024
@srujanchikke
Copy link
Contributor

@Gnanasundari24 I am getting some error while running cypress tests for the redirection flow (three ds auto capture), can we skip it and please merge this PR if all looks good for the time being?

CC: @srujanchikke @pranav-arjunan

@cookieg13 Let's keep all tests in this PR itself.

@dgeee13
Copy link
Contributor Author

dgeee13 commented Sep 11, 2024

@Gnanasundari24 I am getting some error while running cypress tests for the redirection flow (three ds auto capture), can we skip it and please merge this PR if all looks good for the time being?
CC: @srujanchikke @pranav-arjunan

@cookieg13 Let's keep all tests in this PR itself.

3DS flows are tested, those are working fine. No 3DS flow tests are not passing since the no 3DS flow itself is broken @srujanchikke @Gnanasundari24

SamraatBansal
SamraatBansal previously approved these changes Sep 11, 2024
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want real phone numbers to be exposed in tests:

Suggested change
number: "8056594427",
number: "9123456789",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want real phone numbers to be exposed in tests:

Suggested change
number: "8056594427",
number: "9123456789",

@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 12, 2024
}
),
(
"billing.phone.country_code".to_string(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants