Skip to content

fix(connector): [Bambora Apac] failure on missing capture method and billing address requirement in mandates#5539

Merged
likhinbopanna merged 2 commits intomainfrom
bambora_capture_method_fix
Aug 9, 2024
Merged

fix(connector): [Bambora Apac] failure on missing capture method and billing address requirement in mandates#5539
likhinbopanna merged 2 commits intomainfrom
bambora_capture_method_fix

Conversation

@Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Aug 6, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fix for payment failure when capture method is missing in the request and also removed billing address requirements for MIT in mandates

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested through postman:

Scenario 1:

  • Create a payment through bamboraapac without passing capture method:
{
    "amount": 1100,
    "currency": "USD",
    "confirm": true,
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "StripeCustomer",
    "email": "abcdef123@gmail.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "on_session",
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "127.0.0.1"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "John",
            "last_name": "Doe"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "payment_method": "card",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "4005550000000001",
            "card_exp_month": "02",
            "card_exp_year": "26",
            "card_holder_name": "Joseph Doe",
            "card_cvc": "999"
        }
    },
    "billing": {
        "address": {
            "line1": "8th block",
            "line2": "8th block",
            "line3": "8th block",
            "city": "Bengaluru",
            "state": "Karnataka",
            "zip": "560095",
            "country": "IN",
            "first_name": "Sakil",
            "last_name": "Mostak"
        }
    }
}
  • The status should be succeeded

Scenario 2:

  • Create a CIT with bambora apac without passing billing address with it:
{
    "amount": 10000,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "StripeCustomer",
    "email": "abcdef123@gmail.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "off_session",
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "127.0.0.1"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "payment_type": "new_mandate",
    "payment_method": "card",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "4005550000000001",
            "card_exp_month": "02",
            "card_exp_year": "26",
            "card_holder_name": "Joseph Doe",
            "card_cvc": "999"
        }
    },
    "mandate_data": {
        "customer_acceptance": {
            "acceptance_type": "offline",
            "accepted_at": "1963-05-03T04:07:52.723Z",
            "online": {
                "ip_address": "125.0.0.1",
                "user_agent": "amet irure esse"
            }
        },
        "mandate_type": {
            "multi_use": {
                "amount": 8000,
                "currency": "USD"
            }
        }
    }
}
  • the status should be succeeded and collect the mandate_id
  • use the mandate_id to create a MIT with bamboraapac without passing the billing address:
{
    "amount": 6000,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "StripeCustomer",
    "email": "abcdef123@gmail.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "on_session",
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "127.0.0.1"
    },
    // "shipping": {
    //     "address": {
    //         "line1": "1467",
    //         "line2": "Harrison Street",
    //         "line3": "Harrison Street",
    //         "city": "San Fransico",
    //         "state": "California",
    //         "zip": "94122",
    //         "country": "US",
    //         "first_name": "John",
    //         "last_name": "Doe"
    //     }
    // },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    // "billing": {
    //     "address": {
    //         "line1": "8th block",
    //         "line2": "8th block",
    //         "line3": "8th block",
    //         "city": "Bengaluru",
    //         "state": "Karnataka",
    //         "zip": "560095",
    //         "country": "IN",
    //         "first_name": "Sakil",
    //         "last_name": "Mostak"
    //     }
    // },
    "mandate_id": "man_wqD9VRxN4s8cgd6UxlZj",
    "off_session": true
}
  • the status should be succeeded

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug labels Aug 6, 2024
@Sakilmostak Sakilmostak added this to the August 2024 Release milestone Aug 6, 2024
@Sakilmostak Sakilmostak self-assigned this Aug 6, 2024
@Sakilmostak Sakilmostak requested a review from a team as a code owner August 6, 2024 10:28
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 3183a86 Aug 9, 2024
@likhinbopanna likhinbopanna deleted the bambora_capture_method_fix branch August 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

Assignees

@Sakilmostak Sakilmostak

Labels

A-connector-integration Area: Connector integration C-bug Category: Bug

Projects

None yet

Milestone

August 2024 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@Sakilmostak @deepanshu-iiitu @SamraatBansal @likhinbopanna