Skip to content

feat(connector): enable order create for nordea#10945

Merged
likhinbopanna merged 3 commits intomainfrom
enable-order-create-nordea
Jan 20, 2026
Merged

feat(connector): enable order create for nordea#10945
likhinbopanna merged 3 commits intomainfrom
enable-order-create-nordea

Conversation

@hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Jan 14, 2026

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR implements order create flow support for Nordea connector specifically for bank debit payment method. The changes enable Nordea to handle the order creation flow required for bank debit transactions.

Changes made:

  1. Implemented is_order_create_flow_required() method in the ConnectorSpecifications trait for Nordea
  2. Added logic to check if the payment method is bank debit during the authorize flow
  3. Added Nordea to the list of order create bloated connectors in the development configuration

The implementation ensures that:

  • Order create flow is triggered only for bank debit payment methods during authorize flow
  • Complete authorize and setup mandate flows are not affected
  • The connector follows the same pattern as other bloated connectors (trustpay, payme)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Configuration files modified:

Motivation and Context

Nordea connector requires a separate order creation step for bank debit payment methods before the actual authorization can be performed. This is similar to the behavior already implemented for other connectors like TrustPay and PayMe.

Without this change, bank debit payments through Nordea would fail as the necessary order creation flow would not be triggered, preventing successful payment processing.

How did you test it?

Testing steps in this PR: #8133

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Jan 14, 2026
@hrithikesh026 hrithikesh026 requested review from a team as code owners January 14, 2026 09:25
@semanticdiff-com
Copy link

semanticdiff-com bot commented Jan 14, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  config/development.toml Unsupported file format
  crates/hyperswitch_connectors/src/connectors/nordea.rs  0% smaller

jarnura
jarnura previously approved these changes Jan 16, 2026
@hrithikesh026 hrithikesh026 dismissed stale reviews from jarnura and deepanshu-iiitu via 3e8f882 January 19, 2026 07:01
jarnura
jarnura previously approved these changes Jan 19, 2026
@bernard-eugine bernard-eugine added this pull request to the merge queue Jan 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 19, 2026
@hrithikesh026 hrithikesh026 dismissed stale reviews from deepanshu-iiitu and jarnura via 67272e9 January 19, 2026 14:33
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 20, 2026
Merged via the queue into main with commit fe5753f Jan 20, 2026
26 of 27 checks passed
@likhinbopanna likhinbopanna deleted the enable-order-create-nordea branch January 20, 2026 09:39
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@5840551). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10945   +/-   ##
=======================================
  Coverage        ?        0           
=======================================
  Files           ?        0           
  Lines           ?        0           
  Branches        ?        0           
=======================================
  Hits            ?        0           
  Misses          ?        0           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants