Skip to content

Enable moving the console prompt if the console is visible#18332

Merged
brichet merged 1 commit intojupyterlab:mainfrom
brichet:enable_moving_console_prompt
Jan 14, 2026
Merged

Enable moving the console prompt if the console is visible#18332
brichet merged 1 commit intojupyterlab:mainfrom
brichet:enable_moving_console_prompt

Conversation

@brichet
Copy link
Copy Markdown
Contributor

@brichet brichet commented Jan 13, 2026

References

Also when testing locally there seems to be an issue about not being able to change the prompt position when the scratchpad is open

In #18238, we added a way to enable the commands when the console is not in main area, but missed this use case. It uses the fact that the current console contains the activeElement. The menu to change the prompt position is attached to the root of the DOM, not to the node of the console.

Originally posted by @brichet in jupyter/notebook#7790 (comment)

Code changes

Change the function to enable the commands to move the console prompt.
these commands are now enabled if the console tracker has a current widget and if this widget is visible.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Copy Markdown
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@brichet
Copy link
Copy Markdown
Contributor Author

brichet commented Jan 14, 2026

Merging it, the failing tests are not related.

@brichet
Copy link
Copy Markdown
Contributor Author

brichet commented Jan 14, 2026

Thanks for the review @krassowski

@brichet brichet merged commit 83d3344 into jupyterlab:main Jan 14, 2026
85 of 87 checks passed
@brichet brichet deleted the enable_moving_console_prompt branch January 14, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants