Skip to content

fix: cannot extract empty files to InputStream#90

Merged
gotson merged 1 commit into
junrar:masterfrom
andrebrait:fix/gh-88-empty-file
May 31, 2022
Merged

fix: cannot extract empty files to InputStream#90
gotson merged 1 commit into
junrar:masterfrom
andrebrait:fix/gh-88-empty-file

Conversation

@andrebrait

@andrebrait andrebrait commented May 30, 2022

Copy link
Copy Markdown
Contributor

Fixes #88

@codecov

codecov Bot commented May 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #90 (2af8996) into master (1d52d5d) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     54.90%   54.92%   +0.01%     
- Complexity      884      885       +1     
============================================
  Files            90       90              
  Lines          5001     5005       +4     
  Branches        803      803              
============================================
+ Hits           2746     2749       +3     
- Misses         1928     1929       +1     
  Partials        327      327
Impacted Files Coverage Δ
src/main/java/com/github/junrar/Archive.java 63.38% <80.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c56d7...2af8996. Read the comment docs.

@andrebrait andrebrait mentioned this pull request May 30, 2022
Closed
@gotson

gotson commented May 31, 2022

Copy link
Copy Markdown
Member

Thanks a lot, nice implementation.

@gotson gotson merged commit c95a211 into junrar:master May 31, 2022
github-actions Bot pushed a commit that referenced this pull request May 31, 2022
@semantic-release-bot
chore(release): 7.5.2 [skip ci]
24a0210 
## [7.5.2](v7.5.1...v7.5.2) (2022-05-31)

### Bug Fixes

* cannot extract empty files to InputStream ([#90](#90)) ([c95a211](c95a211)), closes [#88](#88)
@github-actions

github-actions Bot commented May 31, 2022

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andrebrait andrebrait deleted the fix/gh-88-empty-file branch June 1, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] "IllegalArgumentException: Pipe Size <= 0" with an empty file in the archive

2 participants

@andrebrait @gotson