Add initial Platform support for reporting discovery issues#4385
Merged
Conversation
6 tasks
36 tasks
36 tasks
77630ed to
c780efd
Compare
36 tasks
This can be useful when inspecting the test plan prior to execution.
This avoids the test from getting skipped if a tool (like Surefire does) inspect the test plan to decide whether a class is a test class.
0eee8e3 to
5f101f0
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
DiscoveryIssuealong with a newissueEncounteredmethod onEngineDiscoveryListener. The launcher reports engines with issues of severityERRORas failed during execution. Which severity is considered "critical" will be made configurable in a later PR.Issue: #242
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotationsChange is documented in the User Guide and Release Noteswill be done in a later PR