fix: handle list-type host in settings and fix [object Object] error display#908
Closed
fqx wants to merge 2 commits into
Closed
fix: handle list-type host in settings and fix [object Object] error display#908fqx wants to merge 2 commits into
fqx wants to merge 2 commits into
Conversation
…display When users manually set `host` to a YAML list in settings.yaml, the backend would store the list object in ServerSettings.host (typed str), causing the web UI to receive a non-string value. Alpine.js x-model then displayed "[object Object]" in the host input, and saving triggered a Pydantic 422 whose array-of-objects detail was joined to "[object Object]". - settings.py: normalize host to string in from_dict() — list values are joined with ", " so the web UI can display and edit them normally - dashboard.js: extract .msg from Pydantic error detail objects instead of calling .join() directly on them, preventing "[object Object]" in all error toasts (fixes two call sites) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Users can now enter multiple bind addresses in the host field separated by commas (e.g. "127.0.0.1, 0.0.0.0"). The existing YAML list format is also handled via the from_dict() normalization added in the previous commit. Changes: - cli.py: split host string by comma before calling uvicorn.run(); print one URL line per address; asyncio.create_server() binds a socket for each host in the list natively - utils/network.py: add is_valid_bind_host() which accepts all valid IPs (including 0.0.0.0 and ::) and hostnames — unlike is_valid_alias() which rejects unspecified addresses - admin/routes.py: validate each comma-separated part of the host field on save so invalid values are rejected with a 400 before they can cause a crash on server restart Backward-compatible: single-address strings and legacy YAML list values both continue to work without any settings migration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
SummaryThis PR enables users to specify multiple bind addresses directly from the web UI, rather than being limited to a single address or the catch-all Why it matters: Binding only to specific interfaces is more secure than listening on all interfaces. A common use case is exposing the server locally and over a private overlay network such as Tailscale, without opening it to every interface on the machine — for example: While this was already supported via manual edits to What changed:
Existing single-address configs and legacy YAML list values continue to work without any migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by a new PR that adapts to the
uvicorn.Config + bind_socket()refactor introduced in #1526. The core logic is the same but thecli.pychanges are rewritten to work with the new pre-bind approach.