feat(tts): forward language parameter to TTS engine#1773
Merged
Conversation
The OpenAI-compatible /v1/audio/speech endpoint accepts an optional 'language' field (e.g. 'german', 'english') but it was silently dropped — AudioSpeechRequest had no language field, TTSEngine never received it, and the upstream Qwen3-TTS model fell back to lang_code "auto". - Add language field to AudioSpeechRequest - Accept and forward language in TTSEngine.synthesize() and stream_synthesize_pcm(), mapped to lang_code for Qwen3-TTS models - Pass request.language in audio_routes.py for all three call sites: native streaming, segmented fallback, and non-streaming synthesis - Log language in all TTS log lines
Owner
|
Thanks for the PR. The request and route-level forwarding look correct, and mapping the API One compatibility detail I noticed is that adding |
Contributor
Author
|
just a gotcha to note: not all models treat the language parameter the same. some want language like "english" or "german" some want it like "en" "de. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAI-compatible /v1/audio/speech endpoint accepts an optional 'language' field (e.g. 'german', 'english') but it was silently dropped — AudioSpeechRequest had no language field, TTSEngine never received it, and the upstream Qwen3-TTS model fell back to lang_code "auto".