fix(i18n): align non-English memory guard strings with JS placeholders#1730
Merged
jundot merged 1 commit intoJun 8, 2026
Merged
Conversation
…olders
`description_template` in all non-English locales used `{ceiling_gb}`
which the JS never replaces, leaving a literal `{ceiling_gb}` in the UI.
The JavaScript interpolates `{tier}`, `{active_pct}`, and `{reclaim_method}`.
`wired_limit_warning` had `{kernel} GB` (causing double "GB" after JS
injects `<strong>37.4 GB</strong>`) and `{requested}` which the JS
never replaces.
Updated 7 locale files (zh, zh-TW, ja, ko, fr, ru, es) with correct
placeholders and proper translations. English (`en.json`) was already
correct and is unchanged.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks for fixing this. The updated placeholders match the dashboard interpolation path, and I verified the non-English locale files no longer leave stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The description_template and wired_limit_warning strings in all non-English locale files use placeholder names that do not match what the JavaScript actually interpolates.
description_template — JS replaces {tier}, {active_pct}, {reclaim_method}; non-English locales had {ceiling_gb} instead, so it appeared verbatim.
wired_limit_warning — JS replaces {kernel} with a value that already includes the unit (e.g. 37.4 GB); non-English locales had {kernel} GB causing double-GB output, and {requested} which is never replaced.
en.json was already correct. This fixes the 7 affected locales: zh, zh-TW, ja, ko, fr, ru, es.
Fix
Updated all 7 locale files to use the correct placeholders and added proper translations (previously these strings were left in English in the non-English files).
Testing
Generated with Claude Code