Fix login page to honor system dark mode setting#1728
Merged
Conversation
The base template's theme initialization script was defaulting to 'light' and never checking prefers-color-scheme. Updated it to default to 'auto' and detect system dark mode via window.matchMedia, matching the behavior of the chat and dashboard pages.
Owner
|
Thanks for the fix. The base template now matches the chat/dashboard auto-theme behavior for initial render, and it keeps explicit light/dark choices unchanged. This looks good to me, and I'm going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The login page on the admin endpoint didn't honor the system dark mode setting, unlike the chat and dashboard pages.
Root Cause
The theme initialization script in
base.htmlwas defaulting to'light'and never checkingprefers-color-schemewhen the stored theme value was'auto'.Fix
Updated the inline theme script in
base.htmlto:'auto'instead of'light'when no theme is stored in localStoragewindow.matchMedia('(prefers-color-scheme: dark)')when the theme is'auto'to detect the system dark mode preferenceThis matches the behavior already used by
chat.html.