add dispatch for dot between Symmetric and Hermitian#236
add dispatch for dot between Symmetric and Hermitian#236araujoms wants to merge 2 commits intojump-dev:masterfrom araujoms:patch-1
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 89.61% 89.63% +0.02%
==========================================
Files 23 23
Lines 2156 2152 -4
==========================================
- Hits 1932 1929 -3
+ Misses 224 223 -1
☔ View full report in Codecov by Sentry. |
odow
left a comment
There was a problem hiding this comment.
This seems reasonable, even if it just kicks the can a little down the road.
|
Could you add tests ? Maybe we could check for ambiguities like https://github.com/jump-dev/MathOptInterface.jl/blob/master/test/runtests.jl#L36 ? |
👍
This should be a separate PR, and probably by me or you. I took a look once and got scared so I stopped. There are too many for @araujoms to deal with. |
|
I don't know how to do that anyway, so I'd be most grateful if you step up. |
Fixes #234
I've only added inner products when both arguments are Symmetric or Hermitian, for a total of 6 additional methods. I think if some user wants to take an inner product between a Symmetric or Hermitian and a general matrix they're just asking for trouble, and it's ok to leave them on their own.