Skip to content

Test that added_... is implemented for concrete types and warn if typ…#870

Merged
blegat merged 3 commits intomasterfrom
bl/concrete_det
Sep 4, 2019
Merged

Test that added_... is implemented for concrete types and warn if typ…#870
blegat merged 3 commits intomasterfrom
bl/concrete_det

Conversation

@blegat
Copy link
Copy Markdown
Member

@blegat blegat commented Sep 4, 2019

…es are missing in test_delete_...

@blegat blegat mentioned this pull request Sep 4, 2019
@blegat blegat added this to the v0.9.2 milestone Sep 4, 2019
Comment thread test/Bridges/utilities.jl Outdated
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 4, 2019

Codecov Report

Merging #870 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   94.72%   94.82%   +0.09%     
==========================================
  Files          76       76              
  Lines        8044     8044              
==========================================
+ Hits         7620     7628       +8     
+ Misses        424      416       -8
Impacted Files Coverage Δ
src/Bridges/Constraint/det.jl 100% <100%> (+1.2%) ⬆️
src/Bridges/Variable/rsoc_to_psd.jl 100% <0%> (+1.33%) ⬆️
src/Bridges/Constraint/soc_to_psd.jl 94.82% <0%> (+3.44%) ⬆️
src/Bridges/Objective/map.jl 58.33% <0%> (+4.16%) ⬆️
src/Bridges/Constraint/slack.jl 98.38% <0%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cb8d9...19de008. Read the comment docs.

@blegat blegat merged commit a3ee2fb into master Sep 4, 2019
@blegat blegat deleted the bl/concrete_det branch October 10, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants