Skip to content

Default to the Windows system tar, but add an escape hatch#250

Closed
DilumAluthge wants to merge 2 commits intomasterfrom
dpa/tar-windows
Closed

Default to the Windows system tar, but add an escape hatch#250
DilumAluthge wants to merge 2 commits intomasterfrom
dpa/tar-windows

Conversation

@DilumAluthge
Copy link
Copy Markdown
Member

@DilumAluthge DilumAluthge commented Jun 19, 2024

Fixes #205
Replaces #206 (closes #206)

This is almost identical to #206, except this PR adds a (non-public internal) tar input as an "escape hatch", so that if necessary the user can provide the correct tar to be used.

For example, the user could manually manipulate their PATH before they run this action, and then they could just do this:

- uses: julia-actions/setup-julia@v2
  with:
    version: '1'
    tar: 'tar'

And then this will just pick up the tar that the user put first in their PATH.

@DilumAluthge DilumAluthge force-pushed the dpa/tar-windows branch 5 times, most recently from d02cc7d to 1b8b1fa Compare June 19, 2024 02:19
@DilumAluthge DilumAluthge marked this pull request as ready for review June 19, 2024 02:29
@DilumAluthge DilumAluthge requested a review from a team as a code owner June 19, 2024 02:29
@DilumAluthge DilumAluthge marked this pull request as draft June 19, 2024 02:35
@DilumAluthge DilumAluthge marked this pull request as ready for review June 19, 2024 02:53
@DilumAluthge DilumAluthge marked this pull request as draft June 19, 2024 19:10
@DilumAluthge
Copy link
Copy Markdown
Member Author

Closed in favor of #206. We can revisit the need for an escape hatch in the future.

@DilumAluthge DilumAluthge deleted the dpa/tar-windows branch June 19, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Using tar on Windows should call $env:WINDIR/System32/tar and not the Git bash provided /usr/bin/tar

1 participant