Fix the build script to handle macOS sed correctly#8
Merged
IanButterworth merged 2 commits intomainfrom Jul 21, 2024
Merged
Conversation
DilumAluthge
approved these changes
Apr 1, 2024
Member
DilumAluthge
left a comment
There was a problem hiding this comment.
We could also just rewrite the entire script in Julia (instead of Bash).
DilumAluthge
reviewed
Apr 1, 2024
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
DilumAluthge
approved these changes
Apr 1, 2024
Member
Author
|
I can test and merge this, update the subproject commit on the action etc. during the next setup-julia release |
sed correctly
Member
|
Bump @IanButterworth Can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise on MacOS it fails with
sed: 1: ".gitignore": invalid command code .