Attempting to do further cleanup the DAP debugger, as per comments by matthiasblaesing#5
Merged
jtulach merged 1 commit intojtulach:lsp_client_dapfrom Jan 5, 2025
Merged
Conversation
jlahoda
commented
Jan 5, 2025
- cleaning up use of String urls, using URIs internally
- cleaning up the breakpoint to not hold paths, but rather only hold FileObjects
- cleaning up the BreakpointAnnotationProvider to not use a weak listener, and holder for the listeners. Using ordinary listeners, which will be held as long as the DataObject exists, and should be automatically GCed when the DO is removed, which is presumably the intent
- renaming (DAP)Utils to DAPStackTraceAnnotationHolder
… matthiasblaesing: - cleaning up use of String urls, using URIs internally - cleaning up the breakpoint to not hold paths, but rather only hold FileObjects - cleaning up the BreakpointAnnotationProvider to not use a weak listener, and holder for the listeners. Using ordinary listeners, which will be held as long as the DataObject exists, and should be automatically GCed when the DO is removed, which is presumably the intent - renaming (DAP)Utils to DAPStackTraceAnnotationHolder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.