Rework async thunks generation to cross module generics infra #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwrighton
commented
Jan 15, 2026
- Add ability for code generating an ILStub to mark that the tokens might be generated
- Funnel through various details to ensure that we trigger creation of the ManifestModuleWrappedMethodIL as needed
- Adjust method fixup signature generation to allow for VersionsWithMethodBody code which is in the MutableModule
- Add a few todos about work we might do to allow cross module compilation of runtime async code.
- Disable this for now though, since its much to complex to test without a working end-to-end scenario (See code in CrossModuleInlineableUncached
- Remove logic added to refer to System.Exception in the EH clause specially
- Add ability for code generating an ILStub to mark that the tokens might be generated - Funnel through various details to ensure that we trigger creation of the ManifestModuleWrappedMethodIL as needed - Adjust method fixup signature generation to allow for VersionsWithMethodBody code which is in the MutableModule - Add a few todos about work we might do to allow cross module compilation of runtime async code. - Disable this for now though, since its much to complex to test without a working end-to-end scenario (See code in CrossModuleInlineableUncached
…o HandleThunksWithCrossModuleGenericsInfraInsteadOfBespokeStuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.