Add letrec arbitrary combinator #193
Conversation
|
I have to say this is probably the best project I've ever seen when it comes to automated code quality management: tests with no failures, lint with no violations, and coverage near 100%, all automated. 👏 |
| } | ||
| });` | ||
| */ | ||
| function letrec(definition) { |
There was a problem hiding this comment.
smart. I see. The lazyArbs trick is because we don't know the key set before calling definition.
lib/arbitrary.js
Outdated
| } | ||
|
|
||
| /** | ||
| - `letrec( |
There was a problem hiding this comment.
I'd prefer triple backtick js comments:
```js
var foo = 1 + 1:
```
|
Github tells me "Changes requested", and I pushed those changes. Is there anything left for me to do to move this forward? Do I need to click a button somewhere? I don't want to be pushy; just wondering if this PR is waiting on me. |
|
I haven't time to review this. It's on my todo list. Sorry for delays. |
|
|
||
| /** | ||
| - ```js | ||
| letrec( |
There was a problem hiding this comment.
is the formatting somehow off here, or is it just my eyes?
There was a problem hiding this comment.
This has been fixed in the latest version. I don't know how to get Git to show that in the PR conversation, but you can see it in the commit.
| }); | ||
| arb.shrink = shrink.noop; | ||
| arb.show = show.def; | ||
| arb = arbitraryBless(arb); |
There was a problem hiding this comment.
the arbitraryBless could rebless the fields too. No need to do this, just a mental not for myself.
|
Thank you! |
Closes #192