Skip to content

Disable checking of contracts.#183

Merged
cpovirk merged 2 commits into
mainfrom
b351867464
Jul 9, 2024
Merged

Disable checking of contracts.#183
cpovirk merged 2 commits into
mainfrom
b351867464

Conversation

@cpovirk

@cpovirk cpovirk commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

We've historically accomplished this with -AsuppressWarnings, but this
CL's solution may be more general. Also, it avoids running some code
entirely, which saves us from having to keep that code updated for the
very new JDKs that we run with. (It might also help performance if we're
lucky, and maybe it moves us a step closer to not needing JavaParser
(though that may be on the way out, anyway).)

We've historically accomplished this with `-AsuppressWarnings`, but this
CL's solution may be more general. Also, it avoids running some code
entirely, which saves us from having to keep that code updated for the
very new JDKs that we run with. (It might also help performance if we're
lucky, and maybe it moves us a step closer to not needing JavaParser
(though that may be on the way out, anyway).)
@cpovirk cpovirk requested a review from cushon July 9, 2024 19:04
@cpovirk

cpovirk commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator Author

Merging despite pre-existing CI failures, for which I've filed #184 and created #185.

@cpovirk cpovirk merged commit aa63538 into main Jul 9, 2024
@cpovirk cpovirk deleted the b351867464 branch July 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants