Change OSGi BSN to org.jspecify.annotations or org.jspecify#569
Change OSGi BSN to org.jspecify.annotations or org.jspecify#569chrisrueger wants to merge 1 commit into
Conversation
based on discussion in jspecify#428 (comment)
|
Sorry, I see now that not only does the Felix doc suggest "org.jspecify" but that so too does one doc I cited earlier. (I had missed the section of that doc that gave actual recommendations in favor of the section that (as I theorized at the time) was demonstrating how to override those recommendations when necessary.) And sadly, that convention was not mentioned by the recommendations I had dug up. It is very possible that "org.jspecify" would be better, but I unfortunately didn't give this discussion time to develop after merging the original OSGi PR, and I pushed the release to Maven in the meantime. While we could immediately release a 1.0.1 with the change, I think it will be simplest at this point to stick with what we have, partially (but not exclusively) because that it's still not 100% clear to me which approach (if either) is most conventional. (I do suspect that it would be "org.jspecify," but I think this is minor enough that it's not worth blocking on.) Sorry again for not giving time for this discussion. I do appreciate the link you dug up about the convention. |
This is a proposal based on discussion in #428 (comment)
I liked the proposal by @bjmi
org.jspecify.annotationsBut what about just org.jspecify ?
There is also the proposal to just use
org.jspecifyorg.jspecifyjspecify/src/java9/java/module-info.java
Line 16 in 5bf4ae4
If this should be kept, then it also makes sense to use the same for the OSGi BSN / Bundle-SymbolicName
This PR should serve to decide which one to use.