Conversation
- Upgrade Spotless to upgrade google-java-format. - Make nested test classes `static` so that we don't end up with [synthetic parameters that upset our JDK-8 integration test](https://bugs.openjdk.org/browse/JDK-8058322). (https://errorprone.info/bugpattern/ClassCanBeStatic!) Thanks to cushon@ for the pointers. While there, rename a test that I should have renamed as part of #270. And update our CI versions to include JDK 21. (I haven't added JDK 22, as we've seen some potential signs of remaining flakiness there.)
Collaborator
Author
|
(Context in internal Google bug 342453778.) |
Contributor
|
you might want to make the Gradle build run on 21, but compile/test/etc on 8-22. You can do this using a gradle daemon toolchain and a java language toolchain, and an env var in your build matrix. This is what Caffeine does and its much cleaner than relying on the jdk used to start the gradle process. |
Collaborator
Author
|
Thanks, that seems to be the consensus advice, which someday I will get around to understanding and implementing in our various projects :) |
This was referenced May 24, 2024
netdpb
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
staticso that we don't end up withsynthetic parameters that upset our JDK-8 integration
test.
(https://errorprone.info/bugpattern/ClassCanBeStatic!)
Thanks to cushon@ for the pointers.
While there, rename a test that I should have renamed as part of
#270.
And update our CI versions to include JDK 21. (I haven't added JDK 22,
as we've seen some potential signs of remaining flakiness there.)