Skip to content

Define a JPMS module for our annotations#105

Merged
cpovirk merged 2 commits into
masterfrom
add-module-name
Apr 29, 2020
Merged

Define a JPMS module for our annotations#105
cpovirk merged 2 commits into
masterfrom
add-module-name

Conversation

@KengoTODA

@KengoTODA KengoTODA commented Apr 26, 2020

Copy link
Copy Markdown
Collaborator

Apply gradle-modules-plugin and replace existing configurations with modularity.mixedJavaRelease which configures --release javac option.

close #104

javap result of module-info

Classfile .../jspecify/build/libs/module-info.class
  Last modified Apr 26, 2020; size 204 bytes
  MD5 checksum e57e5ad61b984f5ef27b6583a6230f74
  Compiled from "module-info.java"
module jspecify.annotations
  minor version: 0
  major version: 53

Major version 53 means Java 9.

javap result of Nullable

Classfile .../jspecify/build/libs/org/jspecify/experimentaldonotuse/Nullable.class
  Last modified Apr 26, 2020; size 443 bytes
  MD5 checksum 3457a0b34780144765f79960198c4c42
  Compiled from "Nullable.java"
public interface org.jspecify.experimentaldonotuse.Nullable extends java.lang.annotation.Annotation
  minor version: 0
  major version: 52

Major version 52 means Java 8.

@KengoTODA KengoTODA self-assigned this Apr 26, 2020
@googlebot googlebot added cla: yes See https://cla.developers.google.com/ labels Apr 26, 2020
@cpovirk

cpovirk commented Apr 29, 2020

Copy link
Copy Markdown
Collaborator

Thanks again.

@cpovirk cpovirk merged commit 789bb79 into master Apr 29, 2020
@cpovirk cpovirk deleted the add-module-name branch April 29, 2020 21:34
@KengoTODA KengoTODA mentioned this pull request Jun 7, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KengoTODA KengoTODA

Labels

cla: yes See https://cla.developers.google.com/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define a JPMS module for our annotations

3 participants

@KengoTODA @cpovirk @googlebot