Allow closing active subscriptions#174
Merged
jsonnull merged 1 commit intojsonnull:fix-subscriptionsfrom May 3, 2024
Merged
Conversation
✅ Deploy Preview for electron-trpc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this PR trpc/trpc#4136, TRPC Client allows users to close active subscriptions.
Closing an active subscription using the current
electron-trpcversion will lead us to this error trpc/trpc#4060 (comment)This PR allows for the closing of active subscriptions. It removes unnecessary code related to tracking the completion of operations and simplifies the logic for error handling and completion. The changes ensure that the observer is properly notified when an operation is complete or when an error occurs.
Generated using OpenSauced.