add justinrainbow/json-schema to tooling page#987
add justinrainbow/json-schema to tooling page#987benjagm merged 5 commits intojson-schema-org:mainfrom
Conversation
|
Hey there 👋! Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like? Someone will review your pull request shortly. In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:
If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out. |
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
|
I have added the image. |
benjagm
left a comment
There was a problem hiding this comment.
Thanks a lot for your help!!
Can you please take a look to my comment?
benjagm
left a comment
There was a problem hiding this comment.
Looks great! Thanks a lot for this PR.
|
Congratulations, @heysujal for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
This PR adds
justinrainbow/json-schemato the tooling page as a validator.As in the mentioned issue, the link for the logo was given. The image is not loading because the URL is not being picked up as it but it is being appended to some directory. Something like below
http://localhost:3000/img/tools/logos/https:/avatars.githubusercontent.com/u/170307068?s=200&v=4I think this can be fixed by making changes to
next.config.jsThis is another issue on its own and I would like to work on it too.
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No