This repository was archived by the owner on Dec 15, 2025. It is now read-only.
Remove allocs from WriteFloat32/WriteFloat64#234
Merged
taowen merged 1 commit intojson-iterator:masterfrom Feb 14, 2018
brian-brazil:float-allocs
Merged
Remove allocs from WriteFloat32/WriteFloat64#234taowen merged 1 commit intojson-iterator:masterfrom brian-brazil:float-allocs
taowen merged 1 commit intojson-iterator:masterfrom
brian-brazil:float-allocs
Conversation
The use of strconv.FormatFloat causes a string allocation, by setting aside a reusable buffer and using strconv.AppendFloat this can be avoided. Before: BenchmarkRespond-4 300 5392189 ns/op 618936 B/op 20010 allocs/op After: BenchmarkRespond-4 300 4713746 ns/op 139744 B/op 10 allocs/op This benchmark is using a custom encoder that calls WriteFloat64 20k times, which is the bulk of the work.
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 83.5% 83.46% -0.04%
==========================================
Files 44 44
Lines 5500 5505 +5
==========================================
+ Hits 4593 4595 +2
- Misses 716 718 +2
- Partials 191 192 +1
Continue to review full report at Codecov.
|
Contributor
|
will merge this pr today. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of strconv.FormatFloat causes a string allocation,
by setting aside a reusable buffer and using strconv.AppendFloat
this can be avoided.
Before:
BenchmarkRespond-4 300 5392189 ns/op 618936 B/op 20010 allocs/op
After:
BenchmarkRespond-4 300 4713746 ns/op 139744 B/op 10 allocs/op
This benchmark is using a custom encoder that calls WriteFloat64 20k
times, which is the bulk of the work.