Native aot type safe read#628
Merged
Merged
Conversation
Test Results 15 files ± 0 15 suites ±0 14s ⏱️ -3s Results for commit 1146c73. ± Comparison against base commit 5f8949b. This pull request removes 28 and adds 4 tests. Note that renamed tests count towards both.This pull request skips 1 test. |
Merged
Contributor
|
Cool! I like it. |
jevansaks
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the
options.Read<T>()extension to take aJsonTypeInfo<T>instead of the non-generic one.This change infers the type parameter when a JTI is passed, which improves readability while also allowing us to explicitly use our serializer context. Additionally, it adds a compiler check to ensure that we're generating a JTI for every type that we explicitly deserialize.