Native aot test app#626
Closed
gregsdennis wants to merge 4 commits into
Closed
Conversation
jevansaks
reviewed
Jan 27, 2024
| <Nullable>enable</Nullable> | ||
| <InvariantGlobalization>true</InvariantGlobalization> | ||
|
|
||
| <PublishAot>true</PublishAot> |
Contributor
There was a problem hiding this comment.
Add:
<IsTrimmable>true</IsTrimmable>
Collaborator
Author
There was a problem hiding this comment.
Doesn't PublishAot cover that?
Collaborator
Author
There was a problem hiding this comment.
The IsTrimmable property defaults to true when configuring a project as AOT-compatible with
<IsAotCompatible>true</IsAotCompatible>.
Do we need to set that separately from PublishAot?
Contributor
There was a problem hiding this comment.
I'm not sure. @Sergio0694 always tells me to include it, perhaps he can give better guidance.
There was a problem hiding this comment.
If you use PublishAot, that's sufficient. IsAotCompatible is used for libraries, but if you're making an app, the former covers everything you need already 🙂
5183898 to
8bc96da
Compare
8bc96da to
ed53a6c
Compare
Collaborator
Author
|
Closing this for now. I think forbidding reflection in the tests is sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #624