Merged
Conversation
jsipprell
approved these changes
Oct 11, 2021
Owner
jsipprell
left a comment
There was a problem hiding this comment.
This feature looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
Link()operation and its underlying syscall to be able to link keys and keyrings to other keyrings. This is necessary if you want to e.g. link a key to multiple keyrings or for moving keys and keyrings between keyrings.See the [keyctl manpage}(https://man7.org/linux/man-pages/man3/keyctl_link.3.html) for details.
I the course, we now have the means to solve the permission denied problem in #6 which is cased by non-modifiable standard permissions when dealing with the user-session keyring (details in issue #6).
Furthermore, the PR fixes the wrong argument order for
Unlink()leading toENODIRerrors.resolves #6