replace mocha and nyc with native node test runner and c8#54
replace mocha and nyc with native node test runner and c8#54wesleytodd merged 3 commits intojshttp:masterfrom
mocha and nyc with native node test runner and c8#54Conversation
5aaf5ef to
20df3ec
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/deep-equal@1.0.1, npm/nyc@15.1.0 |
20df3ec to
e0c2936
Compare
wesleytodd
left a comment
There was a problem hiding this comment.
I am on the fence on adopting the node test runner yet, but I am a fan of trying in one package, so I am approving this. But I will tag in the @jshttp/express-tc in case anyone has strong opinions.
|
relevant express team discussion on the topic of the node test runner, and test runners in general: https://openjs-foundation.slack.com/archives/C02QB1731FH/p1729689394701019 |
bjohansebas
left a comment
There was a problem hiding this comment.
+1 on trying it in a single package for now, probably before releasing, the captain should agree, which in this case is @blakeembrey
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! @Phillip9587 can you work on the conflct? 🙏
e0c2936 to
ad7b5ad
Compare
|
@UlisesGascon Done! |
|
Hey @blakeembrey, could you take a look at this and confirm if you're on board with the changes? Let me know if you have any concerns! |
|
I am going to push this one forward, it is not a blocking review and Blake has much more important things going on in life so I don't want to force attention on this which is rather low risk. |
This PR refactors the test setup by replacing Mocha and NYC with Node.js's native test runner (
node:test) andc8for coverage reporting.Key Changes:
c8for code coverage.deep-equalwith nativeassert.deepEqual.Benefits:
These changes modernize the testing framework, reduce external dependencies, and uphold code coverage standards using built-in Node.js capabilities.