You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @ssbarnea, I had to revert the default of --quiet to False because of a practical constraint.
Here are the details:
--quiet was set up to be a "flag" (is_flag=True). So if it's default to False, you can add --quiet into your command to silence pydoclint, and if you don't add --quiet, pydoclint will print each file it processes. But if it's default to True, there's no way to make pydoclint print each file it processes.
This is a design oversight (I shouldn't have made it a "flag"), but now it's too late to change it without breaking things for a lot of users.
Worse yet, if I turn --quiet into not a flag, the error message would not be informative nor actionable:
Usage: pydoclint [OPTIONS] [PATHS]...
Try 'pydoclint -h' for help.
Error: Invalid value for '-q' / '--quiet': '.' is not a valid boolean.
(I can't improve this error message, because it comes from the click package that controls all config options.)
So after some debate, I think the most practical option is to revert to the old behavior. Fortunately, you can use your old workaround, which sets the --quiet flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237.
Reverts the changes in #236 (which was to address #233).