Fix misleading error messages in replaceSync/replace and fix typo in MediaList-impl.js#4108
Merged
domenic merged 2 commits intomerge-cssstylefrom Mar 13, 2026
Merged
Fix misleading error messages in replaceSync/replace and fix typo in MediaList-impl.js#4108domenic merged 2 commits intomerge-cssstylefrom
replaceSync/replace and fix typo in MediaList-impl.js#4108domenic merged 2 commits intomerge-cssstylefrom
Conversation
…mpl.js Co-authored-by: domenic <617481+domenic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from PR #4092 review comments
Fix misleading error messages in Mar 13, 2026
replaceSync/replace and fix typo in MediaList-impl.js
domenic
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceSync()andreplace()combined two distinct failure conditions into a single check with a single error message, causing the "non-constructed" message to appear even when the sheet was constructed but mid-replacement.Changes
CSSStyleSheet-impl.js: Split the!this._constructed || this._disallowModificationguard into two separate checks in bothreplaceSync()andreplace(), each with an accurate message:"Cannot call replaceSync/replace on non-constructed CSSStyleSheet.""The stylesheet is currently being modified."(consistent with#checkModificationAllowed())MediaList-impl.js: Fix typo"spec-complaint"→"spec-compliant"in comment.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.