Better reflection support: take 2#2813
Conversation
|
Do you know of any cases where https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#rules-for-parsing-integers would give different results than Also the first couple of commits could be their own independent PR. |
|
We could just adapt the whitespace trimming part of 24d5364 to use with parsing integers, yes. I'm more interested in comments on the approach right now than treating this as something to be merged directly. :) |
2542134 to
c610585
Compare
I guess I gave those over in #2790 (comment), oops. Do you think it's worth proceeding by trying to merge a v1 without enumerated attribute support? I'd be hesitant to do that in the HTML Standard, but for jsdom it's a definite improvement over our current situation, so I'd be fine with that here. Still, it'd be awesome if we could figure out enumerated attributes too. Otherwise, hmm. I wonder if we should abstract the code we see repeated here a few times for URL handling. E.g. in jsdom (not webidl2js), a util like |
|
Updated for the latest webidl2js change. Most of the concerns raised in #2790 should now be fixed (with the exception of state-related stuff, which we'll punt into the future for now). |
domenic
left a comment
There was a problem hiding this comment.
Looking good. Don't forget to avoid merging until webidl2js is released!
Same goal as #2790, but uses an approach based on IDL extended attributes. So far works pretty well but the real test will be enumerated attributes, which I'll look at later.
This depends on jsdom/webidl2js#161 and #2822.