Merged
Conversation
fd0f507 to
b9d02ab
Compare
domenic
reviewed
Jan 9, 2020
This was referenced Jan 10, 2020
domenic
approved these changes
Jan 11, 2020
Member
domenic
left a comment
There was a problem hiding this comment.
LGTM with potential test improvements. I'll leave it up to you whether to merge or continue iterating; I don't want to slow down all this awesome work.
...orm-tests/to-upstream/html/semantics/forms/the-input-element/default-type-dont-upstream.html
Outdated
Show resolved
Hide resolved
With the exception of the removal of "datetime" <input> type state, these changes do not appear to be observable (or testable).
Even though this is unobservable, when we refer to the <input>'s value we should always use input._value, to avoid calling the complex value getter.
Restore to the original HTML definition of nonexistent for anything other than type=week.
Also make sure to use ASCII lowercase instead of Unicode lowercase during comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these changes are not observable and for consistency benefits only. Two more substantive changes are implementing
<input>value rewrite duringtypechange, and proper validation support for<input type=time min max>whenmin > max.Tests for reversed range are in web-platform-tests/wpt#21103, which is included in this roll.