fix(Window): Avoid re‑assigning module.exports#2771
Closed
ExE-Boss wants to merge 1 commit intojsdom:masterfrom
Closed
fix(Window): Avoid re‑assigning module.exports#2771ExE-Boss wants to merge 1 commit intojsdom:masterfrom
module.exports#2771ExE-Boss wants to merge 1 commit intojsdom:masterfrom
Conversation
Co-Authored-By: Pierre-Marie Dartus <p.dartus@salesforce.com>
TimothyGu
approved these changes
Jan 2, 2020
Member
|
I'd rather figure out a way to break the cycle. In my opinion this just replaces one hack around circular requires with another hack around circular requires. |
Contributor
Author
|
Adding properties to |
Member
|
I disagree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also allows us to move the
require("../living/interfaces")call to the top.Note that this will once again cause issues once Window is converted to WebIDL unless jsdom/webidl2js#154 is merged first.
Extracted from #2548.
review?(@pmdartus, @TimothyGu)