Last weekend I really needed Attr as Node again, and my attempted to do some refactoring turned out largely successful:
https://github.com/Robbert/jsdom/commits/issue-1641

I expect more work needs to be done to fully support Attr everywhere, in TreeWalker for example, I guess I should use annevk's commits to the DOM standard as checklist.

The main difficulty was the cyclic dependency of Node ⇒ attributes.js ⇒ Attr ⇒ Node, I noticed domenic ran into this issue earlier (#1247 (comment)). Since any type of Node usually is created through the Document, I chose to follow this pattern to remove the direct dependency of attibutes.js on Attr, and instead Attr is created through the ownerDocument of the ownerElement of the NamedNodeMap. This way no direct dependency on Attr is required.

Also, I'm registering all Node constructors on the Document implementation in a similar fashion as the custom element constructors for the HTML DOM are registered. See: Robbert@a62ec5d In another DOM implementation I worked on previously this approach worked splendidly.

If someone has time to give their opinion on this approach sometime, I can process the feedback and after that finish up details like TreeWalker support and updating the tests.

Uh oh!

Make Attr inherit from Node again #1641

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions